Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.- 'left-top' => t('Top') . ' ' . t('Left'),
- 'center-top' => t('Top') . ' ' . t('Center'),
- 'right-top' => t('Top') . ' ' . t('Right'),
- 'left-center' => t('Center') . ' ' . t('Left'),
Not every language could combine 2 word in this way :)
eg:
In Eng, you would say:
Top Left
In other language it is:
Left Top
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | 2037847-join-string-d7.patch | 1.21 KB | droplet |
| #4 | 2037847-join-string.patch | 1.4 KB | droplet |
Comments
Comment #0.0
droplet CreditAttribution: droplet commentedUpdated issue summary.
Comment #0.1
droplet CreditAttribution: droplet commentedUpdated issue summary.
Comment #1
amourowAgreed, it's better described in a string for each spot in this case and good for translation.
Comment #1.0
amourowUpdated issue summary.
Comment #2
droplet CreditAttribution: droplet commentedfix_string.patch queued for re-testing.
Comment #4
droplet CreditAttribution: droplet commentedsame patch, reroll only
Comment #5
droplet CreditAttribution: droplet commentedComment #6
droplet CreditAttribution: droplet commented4: 2037847-join-string.patch queued for re-testing.
Comment #7
penyaskitoReviewed and looks a nice fix. I run grep for checking that there are not more occurrences of this after this patch, and does not look like.
Comment #8
webchickWow. That is utterly bizarre.
Git blame led me to #371374: Add ImageCache UI Core so this was part of the initial patch. No idea how I missed it back in 2009. :) I chalk it up to excitement about having an image cache UI in core. :D
Committed and pushed to 8.x. Thanks!
This can likely be backported to 7.x as well.
Comment #9
droplet CreditAttribution: droplet commentedComment #10
dawehnerJust wonder whether we should also remove the unnecessary whitespaces automatically.
Comment #11
izus CreditAttribution: izus commentedi tested path #9,
it applied well and the result looks good for me.
Thanks
Comment #13
longwave9: 2037847-join-string-d7.patch queued for re-testing.
Comment #14
longwaveAbove fail was an auto retest of an RTBC patch, failure was a bot fluke (probably disk space)
Comment #16
droplet CreditAttribution: droplet commented9: 2037847-join-string-d7.patch queued for re-testing.
Comment #17
droplet CreditAttribution: droplet commentedTest bots issues only, back to RTBC
Comment #19
David_Rothstein CreditAttribution: David_Rothstein commentedCommitted to 7.x - thanks!
Comment #20
David_Rothstein CreditAttribution: David_Rothstein commentedDrupal 7.27 was a security release, so this is now scheduled to go out in Drupal 7.28 instead.