Allow replacement variables in fields "This value", "Then" and "Or"

Good catch. Fixed in the next version but here's a patch to hold you until then.

Whoa. Sorry. Here's one that actually works.

I noticed something in this patch ...
variable $then is called twice in the if-else statements

@@ -221,7 +221,7 @@ class ViewsConditionalHandler extends views_handler_field {
if (strpos($then, 'DATE_STAMP') !== FALSE) {
$then = str_replace('DATE_STAMP', format_date(REQUEST_TIME), $then);
}
- elseif (strpos($then, 'DATE_STAMP') !== FALSE) {
+ if (strpos($then, 'DATE_STAMP') !== FALSE) { ----> should this be $or ?
$or = str_replace('DATE_STAMP', format_date(REQUEST_TIME), $or);
}

The patch worked for me, btw :)

Patch on #2 worked perfectly.

Thank you very much.

Patch from #2 works for me.

But @liniko123 is right. it seems that the patch from #2 has a bug.

So the correct one is attached.

Patch #8 is working.
Can it be added to the oficial release?

Hi, patch #8 works!
Please commit it.

Hi, I've tried patches #2 and #8 and neither are working for me. I'm trying to compare two integers using the 'This value' field. Any help would be much appreciated :)

Hi @pepsimxm.

I believe the issue's scenario is different from what you reported.

This issue is about a bug not allowing us to use replacement variables inside the option "Otherwise, output this...".
Check the image below.
The red square is marking the option where this issue happened and where it is fixed by the patch #8.

You will see that after patch #8 I'm able to use replacement variables on both options "Then output this..." and "Otherwise, output this..." (before patch #8 it was working only for "Then output this...").

Perhaps I did not understood what you reported.

I'm trying to compare two integers using the 'This value' field.

As far I can understand you are trying to do something like "[field_1] == [field_2]" or "[field_1] == 29" directly on "This value" option.
I believe this is not the correct use of the options.

For instance if I want to compare "field_1" with the integer value "29" I can use the following options:
If this field ==> select "field_1" in the list
Is ==> select "Equal to" in the list
This value ==> fill with the value 29 (no quotes)
Then output this ==> fill with text to output when true
Otherwise output this ==> fill with text to output when false

If I need to compare "field_1" with "field_2" it would be the same with one difference:
This value ==> fill with [field_2]

Anyway if you are trying to use a replacement variable at "This value" option and it is not working then it is a new issue not covered by the patch #8.

Well I hope you find my answer helpful.

Regards,
Gilsberty

Hi Gilsberty, thanks for the quick response.

Ok, In understand. The reason why I thought this thread may work for this issue was that it has been closed as a duplicate of 'Replacements in 'This value' field' https://drupal.org/node/2069013. I'll post my question in there now.

Hi @pepsimxm.

I tested and confirmed the bug.
I believe I'm able to write a patch for it based on patch #8.
Please let me try.

Regards,
Gilsberty

@gilsbert, I do not think that it is a good idea to mix all problems in the one issue.

Hi @JustBlackBird.

I understand we should not write one patch for two different issues.

But the original issue and what @pepsimxm reported at #11 are so linked each other that a patch only for #11 would require patch #8 to be applied first. Also the lines to be changed are continuous and I thought - only for this specific case - that only one patch would be better.

I know it all appears different from what I wrote at #12 but that time I had hope that @pepsimxm was not using the options correctly which is not the case unfortunately.

The patch is almost finished.
Let me post it here and check it please.

Regards,
Gilsberty

Here we go.

The patch #18 is equal patch #8 in essence.
I added the treatment for replacement variables on the option "this value".
The date stamp fix is not changed so I hope nobody will find new issues from it.

Please let me know if the patch is working for you.

Regards,
Gilsberty

Hi Gilsbert - I've applied patch #18 and it's working for me... and square brackets around the replacement patterns work too.

Thanks a lot for your help!

Hi.

Thank you very much for testing it.

I would like to thanks @MChittenden and @JustBlackBird because they did an amazing job with the previous patches.
Honestly speaking my contribution was very little.

I'm marking the issue as RTBC hoping the patch may be applied in a future release.

Regards,
Gilsberty

Excellent, the patch in #18 is just what I needed!

patch #18 works GREAT, can we get this rolled into a new release? Would be very convenient! This module should be WAY more popular than the numbers would indicate...

I can confirm that patch #18 works for us too. Should certainly see about getting this in a new release.

I'm rerolled patch #18.

Committed, doing next release (7.x-1.2)