#1784234: Change notice: Use schema.org types and properties in RDF mappings introduced didn't get a full code review.
Here are some fixes.

Files: 
CommentFileSizeAuthor
#4 rdf-2036765-4.patch12.58 KBtim.plunkett
PASSED: [[SimpleTest]]: [MySQL] 56,757 pass(es).
[ View ]
#1 rdf-cleanup-2036765-1.patch12.56 KBtim.plunkett
PASSED: [[SimpleTest]]: [MySQL] 56,923 pass(es).
[ View ]

Comments

tim.plunkett’s picture

Status:Active» Needs review
StatusFileSize
new12.56 KB
PASSED: [[SimpleTest]]: [MySQL] 56,923 pass(es).
[ View ]
linclark’s picture

Status:Needs review» Reviewed & tested by the community

Thanks for reviewing this and making the changes. The changes make sense to me and do make the tests clearer.

alexpott’s picture

Status:Reviewed & tested by the community» Needs work
Issue tags:+Needs reroll

Needs a reroll...

git ac https://drupal.org/files/rdf-cleanup-2036765-1.patch
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 12859  100 12859    0     0  28920      0 --:--:-- --:--:-- --:--:-- 35326
error: patch failed: core/modules/rdf/lib/Drupal/rdf/Tests/StandardProfileTest.php:162
error: core/modules/rdf/lib/Drupal/rdf/Tests/StandardProfileTest.php: patch does not apply
tim.plunkett’s picture

Status:Needs work» Needs review
StatusFileSize
new12.58 KB
PASSED: [[SimpleTest]]: [MySQL] 56,757 pass(es).
[ View ]

The patch context conflicted, not any of the changes.

Gaelan’s picture

Issue tags:-Needs reroll

No longer needs reroll.

scor’s picture

Status:Needs review» Reviewed & tested by the community

back to RTBC.

alexpott’s picture

Status:Reviewed & tested by the community» Fixed

Committed d455ade and pushed to 8.x. Thanks!

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.