[D7] Thirty Suns

Hello there, and thank you for your contribution. I'm however a little confused about what your module does exactly. Perhaps adding some links to the project page will make it clear. You can use HTML a tags in your .info file's description field.

Please correct these ventral review errors: http://ventral.org/pareview/httpgitdrupalorgsandboxafeijo2024717git

Manual review:
- Drupal 7 requires PHP 5.2 already, so I think it's not necessary add PHP dependency explicitly in your .info file.
- package = Other will be assumed, so not necessary to set it either.

thirty_suns_menu()

- access arguments should be an array of parameters to pass to the access callback function which is user_access by default.
'access arguments' => array('administer site configuration'), will do the job.
- Consider moving the admin function to a thirty_suns.admin.inc file.

thirty_suns_admin()

- In your t() calls, do not use raw HTML in the first parameter which should use placeholders as necessary to make it possible (and easy) to translate. It's advised to use inline HTML for anchor tags though (so translator is aware of what the URL points to and its context - Sorry I could not find the relevant help doc yet).
- There is a theme function to theme HTML lists. I think it would be better if you use it.
Note that using multiple line in t() function is completely OK. But try to make easy to translate at a later point.
For example, you could apply t() to each li element and use theme functions to theme the list. Then, combine all the string bits into a single string without translation (we have already used t() function).
- The block will be shown to anonymous and other registered users. Please add appropriate access wrapping.

I'm marking this as "needs work" because of the access restriction stuff and the t() function stuff. Others are more of suggestions.
Good luck!

PS, you need to add a .install file to remove variables created by your module.
See hook_uninstall().

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Thanks Alessandro.
What I meant by "The block will be shown to..." is that the user must use role-specific access restrictions to hide the block as appropriate. Search module, for example will not display the search block if the current user has no access to the block.
This is just a suggestion - consider adding a hook_permission implementation and wrap access to the block using sensible access controls.

You will also need to remove the master branch from the repo.
In your .module file, change the following line to use the t() function.
return '30suns username not informed, visit the '.l('configuration page', 'admin/config/system/30suns');
to
return t('30suns username not informed, visit the <a href="@config-url">configuration page</a>', array('config-url' => url('admin/config/system/30suns')));

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

I'm a robot and this is an automated message from Project Applications Scraper.

fixing description