Move $drupal_hash_salt to settings()

Related issue #1555862: DrupalWebTestCase::drupalGetToken() does not add hash salt

#1: drupal-drupal_hash_salt-2036259-1.patch queued for re-testing.

We also need to make the change in install.core.inc, then I think this should be ok.

#7: 2036259-7.patch queued for re-testing.

Spoke to chx on IRC, we briefly looked into debugging this. There are no real errors in the logs, so at the moment we have no more info than the qa result page...

Assigning to chx at his request - he is going to take a look and see what's going down.

Due to #2171683: Remove all Simpletest overrides and rely on native multi-site functionality instead, this patch should pretty much work as-is now.

Re-rolled against HEAD and converted new code that accesses the global variable.

1. Fixed drupal_rewrite_settings() does not import newly written settings into Settings singleton.
2. Removed the now obsolete/unnecessary 'drupal_' prefix from setting name.

14: global.hashsalt.14.patch queued for re-testing.

Heh, yeah, it was very hard to find an accurate variable name in there, because the entire function is about $settings. I considered $new_settings, $settings_variables, $settings_values, but all of those would be even more ambiguous within the scope of that function body. ;)

Thus, the $settings in settings.php are the $settings_settings :-)

Any change to move forward here? :-)

This patch contains changes that conflict with #2176621: Remove global $databases, and in turn, the latter contains a fix that currently blocks #1351352: Distribution installation profiles are no longer able to override the early installer screens

Looks great - Drupal installs successful with this patch and generates a hash salt in seetings.php as expected.

+++ b/core/includes/bootstrap.inc
@@ -1662,10 +1662,13 @@ function drupal_get_user_timezone() {
+  // This should never happen, as it breaks user logins and many other services.
+  // Therefore, explicitly notify the user (developer) by throwing an exception.
+  if (empty($hash_salt)) {
+    throw new \RuntimeException('Missing $settings[\'hash_salt\'] in settings.php.');
+  }

Nice!

Yes, this looks great. This was held up for ages. Amen to #2171683: Remove all Simpletest overrides and rely on native multi-site functionality instead!

Committed/pushed to 8.x, thanks!

I have updated the CR to indicate that it is better to use drupal_get_hash_salt() in both D7 and D8, rather than accessing the variable/setting directly.