[D7] Language Switcher Settings

Hi Benjamin,
Thank you for your project application.

Please correct the errors reported in this page: http://ventral.org/pareview/httpgitdrupalorgsandboxrbf2035401git

Some other points

- Why do you want to delete a specific entry from system table during hook_uninstall ?
- the current hook_uninstall implementation does not remove variables from the 'variable' table with pattern language_switcher_settings_*.
Please add db_query to delete the variables during an uninstallation.
- In language_switcher_settings.admin.inc, line 27, you can remove the em tags and use the % placeholder to add the em tags.
- Can we also validate the destination page when the admin form is submitted ?

I could not install the module yet. But I'll definitely write a better review when we get the ventral stuff done :)

Good luck!

Nice, simple, very strait forward module.
I've tested it and it works just fine.
However there are still some standards issues that must be fixed before it gets approved:

1. There are still issues on the PAReview.sh automatic review here http://ventral.org/pareview/httpgitdrupalorgsandboxrbf2035401git
2. create a major version branch and remove the master branch, like explained in this post:
https://drupal.org/empty-git-master
3. In the README.txt file, lines should have less that 80 characters.
4. At language_switcher_settings.module, on lines 32 and 33 should use t() function.

When you fix this issues don't change status to 'fixed' yet. Set it to 'Needs review', so other users review your module and comment if they find other issues.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

There is a module called https://drupal.org/project/language_switcher_fallback

Why not create a patch for that? At-least mention it in similar modules.

Patch for mine would be admin page, and change of one line in my code. Not complex.

Review checklist states:
1.2 Ensure your project is not a duplication.
You should really spend some time searching for modules which provide similar functionality. As we prefer collaboration over competition we want to prevent having duplicating modules on drupal.org. If the differences between your module is not too fundamental for patching an existing one, we would love to see you joining forces and concentrate all power on enhancing one module. (If the existing module is abandoned, please think about taking it over).

Also if you want your project to be reviewed, you really need to consider the review bonus.

1. Yes man, there still seems to be some issues here: http://ventral.org/pareview/httpgitdrupalorgsandboxrbf2035401git
2. So now you have a 7.x-1.x branch.
Now you have to delete the master branch.
Here: https://drupal.org/empty-git-master
at item 6. there is the command for deleting master branch:

git branch -D master
git push origin :master

Module working good!

All the issues above appear to not be fixed, as well it appears to be a duplicate. Not saying anything new that hasn't been said, just changing Status to "needs work" as they have not been addressed.

Closing due to lack of activity. Feel free to reopen if you are still working on this application (see also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.