Add a dedicated @FieldWidget annotation

tagging

Yay ! Thanks a lot for this :-)

+++ b/core/modules/field/lib/Drupal/field/Annotation/FieldWidget.phpundefined
@@ -0,0 +1,90 @@
+ * Widgets handle the form of fields.

A bit shaky :-).
Maybe "Widgets handle how fields are displayed in edit forms" ?

+++ b/core/modules/field/lib/Drupal/field/Annotation/FieldWidget.phpundefined
@@ -0,0 +1,90 @@
+ * Additional annotation keys for formatters can be defined in
+ * hook_field_formatter_info_alter().

s/formatter/widget/ :-)

+++ b/core/modules/field/lib/Drupal/field/Annotation/FieldWidget.phpundefined
@@ -0,0 +1,90 @@
+  /**
+   * The name of the module providing the widget.
+   *
+   * @var string
+   */
+  public $module;

I think there was some movement on that front while I was afk - where do we stand with those now, isn't that automatically added ?

+++ b/core/modules/field/lib/Drupal/field/Annotation/FieldWidget.phpundefined
@@ -0,0 +1,90 @@
+   * The name of the widget formatter class.

"The name of the widget class" ?

+++ b/core/modules/field/lib/Drupal/field/Annotation/FieldWidget.phpundefined
@@ -0,0 +1,90 @@
+  /**
+   * Does the field widget handles multiple values at once.
+   *
+   * @var array
+   */
+  public $multiple_values = FALSE;

@var boolean :-p

Additionally, we support an optional "weight" property (currently only used by HiddenWidget AFAIK, that's the specific case for which the propery was introduced). The doc for that in hook_field_widget_info() (before the "Widgets as plugins" patch) was :
"weight: (optional) An integer to determine the weight of this widget relative to other widgets in the Field UI when selecting a widget for a given field instance".
It should default to NULL, though.

WidgetPluginManager::$default should be removed.

Also, #1985344: Add a dedicated @FieldFormatter annotation also took care of removing FormatterFactory (adding the corresponding code in createInstance() override in FormatterPluginManager - see commitdiff).
Dunno the reasons why this was done in one go back then, but should we do the same here ?

Looks good! Thanks!

Opened #2041423: Rely on 'provider' instead of 'module' for Field plugin types

Committed 4fc16f8 and pushed to 8.x. Thanks!

Cool !
Updated https://drupal.org/node/1796000

This actually meant WidgetFactory is never used, see #2052751: WidgetFactory is not used anywhere so it should be removed for the removal of it.

Forgot one 'formatter' leftover.

Ah, indeed.

No kidding ?

#11: 2035315-11.patch queued for re-testing.

Committed 637e6fb and pushed to 8.x. Thanks!

resetting title