Create hook_help for Menu link module

Since there is currently no help for this module, in violation of the Documentation Gate, this is a critical issue.

I think that this help text is fine. However, I am not sure about the links:

 '/admin/help/menu','@menu' => '/admin/structure/menu'))

a) You need to use the url() function to make internal links.
b) I don't think linking to admin/structure/menu with link text "Menu module" is a good idea. Normally within help we just link to the other module's help page, not the configure page. So probably we just need one link to the Menu module's help.

c) Also, modules are proper names so "Menu Link module" is the right name, not "Menu link module".

#6: create-help-text-menu_link-2033413-6.patch queued for re-testing.

Thanks!

"It is required by the Menu module which provides an interface for managing menus." ==> needs a comma before "which".

Other than that, This text looks good to me.

I haven't seen any other url() problems but I'll keep an eye out. You only need url() for doing within-site links, not external links to drupal.org etc.

Looks good to me! Can someone who didn't write the patch please install and test? Check that the formatting is fine and that the link works. Then mark it "RTBC" if all is well. Thanks!

Tested manually and all is well :)

+++ b/core/modules/menu_link/menu_link.moduleundefined
@@ -7,6 +7,16 @@
+      $output .= '<h3>' . t('About') . '</h3>';
+      $output .= '<p>' . t('The Menu Link module allows users to create menu links. It is required by the Menu module, which provides an interface for managing menus. See the <a href="@menu-help">Menu module help page</a> for more information.', array('@menu-help' => url('admin/help/menu'))) . '</p>'; ¶
+      return $output;
+  }

Trailing whitespace here.

I let that slide because we have git apply --whitespace=fix :)

That tool may exist, but that doesn't mean all maintainers use it when applying patches. I usually use the "patch" command to apply patches for docs, not git apply.

Okay, let's not wait for a whitespace then :)

Committed/pushed to 8.x, thanks!

diff --git a/core/modules/menu_link/menu_link.module b/core/modules/menu_link/menu_link.module
old mode 100644
new mode 100755

we need a followup for this

Fixed locally and pushed. I usually spot those but apparently not this time...

awesomeness, thanks!

Needs a reroll with updated links

Should be fine... Can someone manually test to verify the link works in the latest Drupal 8?

tag

Manually Tested and works as intended. Two Thumbs up.

Committed and pushed to 8.x. Thanks!