Followup from #2022897: Shift responsibility for creating unique config id/machine name off of (views) block plugins and onto BlockFormController where a modules folder is introduced. this module should be there as well

CommentFileSizeAuthor
#5 move_tests-2031881-5.patch4.41 KBplopesc
#3 move_tests-2031881-3.patch21.4 KBplopesc
#1 move_tests-2031881-1.patch21.25 KBplopesc

Comments

plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
Status: Active » Needs review
StatusFileSize
new move_tests-2031881-1.patch21.25 KB

Hello

Attaching patch that moves block_test_views to tests/modules folder.
I found that block_test module was placed in tests folder. Then I moved it to tests/modules/block_test folder.

If you consider it shold be moved to tests folder again, just write it ;)

Regards

Status: Needs review » Needs work

The last submitted patch, move_tests-2031881-1.patch, failed testing.

plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
Status: Needs work » Needs review
StatusFileSize
new move_tests-2031881-3.patch21.4 KB

Rerolling, given that http://drupalcode.org/project/drupal.git/commit/a4c65be modified files affected by this issue.

Regards.

ParisLiakos’s picture

ParisLiakos commented

hi, thanks for the patch!
could you maybe use
git diff -M when rolling it? it makes reviewing a lot easier and size a lot smaller:)
thanks again for your time!

plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
StatusFileSize
new move_tests-2031881-5.patch4.41 KB

Hello

Thanks for your point, I've learned a new git diff option ;)

Here is the patch re-rolled.

Regards.

ParisLiakos’s picture

ParisLiakos commented
Status: Needs review » Reviewed & tested by the community

looks great, thanks:)

ParisLiakos’s picture

ParisLiakos commented

doublepost.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 9e4991d and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.