It seems we missed some of the hook_rdf_mapping implementations when we were removing the hook. These should be removed.

CommentFileSizeAuthor
#9 remove_mentions_hook_rdf_mapping-2030467-9.patch1.44 KBpjbaert
#7 remove_mentions_hook_rdf_mapping-2030467-7.patch1.44 KBpjbaert
#5 2030467-5_rdf-mapping-refs.patch1.45 KBkrlucas
#5 interdiff-2030467-4-5.txt531 byteskrlucas
#4 2030467-4_rdf-mapping-ref.patch1.34 KBkrlucas
#4 interdiff-2030467-3-4.txt510 byteskrlucas
#3 2030467-3_rdf-mapping-refs.patch783 byteskrlucas

Comments

linclark’s picture

linclark commented
Title: Remove remaining hook_rdf_mapping implementations » Remove mentions of hook_rdf_mapping
Issue tags: -Novice

Webflo got the remaining implementation in #2030953: Remove node_rdf_mapping()., so I'm going to refocus this issue.

hook_rdf_mapping is used as an example in system.api.php for hook_module_implements_alter. It should be removed.

krlucas’s picture

krlucas commented
Assigned: Unassigned » krlucas
Issue summary: View changes

This should be pretty straightforward. I'll post a patch momentarily.

krlucas’s picture

krlucas commented
Status: Active » Needs work
StatusFileSize
new 2030467-3_rdf-mapping-refs.patch783 bytes

Ok this patch removes the mention of rdf_mapping in system.api.php. However there's still another mention of hook_rdf_mapping in a comment for hook_rdf_namespaces() in core/modules/rdf/rdf.api.php. Unfortunately I don't know enough about that hook and its replacement to update the comment intelligently (yet).

krlucas’s picture

krlucas commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-2030467-3-4.txt510 bytes
new 2030467-4_rdf-mapping-ref.patch1.34 KB

Here's the patch again with an updated comment for hook_rdf_namespaces.

krlucas’s picture

krlucas commented
StatusFileSize
new interdiff-2030467-4-5.txt531 bytes
new 2030467-5_rdf-mapping-refs.patch1.45 KB

Minor grammar change.

marvil07’s picture

marvil07 commented
Assigned: krlucas » Unassigned
Status: Needs review » Needs work
Issue tags: +Documentation, +developer, +Novice

Change is about documentation, looks fine, sadly it does not apply anymore.
hint: some of system.api.php is moved to module.api.php.

pjbaert’s picture

pjbaert
Primary language Dutch
commented
Status: Needs work » Needs review
StatusFileSize
new remove_mentions_hook_rdf_mapping-2030467-7.patch1.44 KB

Reroll

marvil07’s picture

marvil07 commented
Status: Needs review » Needs work

Thanks for the re-roll.

+++ b/core/modules/rdf/rdf.api.php
@@ -14,9 +14,9 @@
- * namespace prefix.
+ * namespaces prefixes.

I think you mean namespace instead of namespacces.

pjbaert’s picture

pjbaert
Primary language Dutch
commented
Status: Needs work » Needs review
StatusFileSize
new remove_mentions_hook_rdf_mapping-2030467-9.patch1.44 KB

Whoops, that's correct @marvil07
Updated patch:

+++ b/core/modules/rdf/rdf.api.php
@@ -14,9 +14,9 @@
- * namespace prefix.
+ * namespace prefixes.
koence’s picture

koence commented
Status: Needs review » Reviewed & tested by the community

I noticed @pjbaert updated the namespace line mentioned in #8. I presume this is rtbc.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Documentation is not frozen in beta. Committed 06f947c and pushed to 8.0.x. Thanks!

  • alexpott committed 06f947c on 8.0.x 
    Issue #2030467 by krlucas, pjbaert: Remove mentions of hook_rdf_mapping

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.