There was 1 failure:

1) commandCase::testUnknownOptions
Unexpected exit code: /home/helmo/src/drush/drush --debug --nocolor version --pipe --magic=1234
Failed asserting that 0 matches expected 1.

/home/helmo/src/drupal/drush/tests/drush_testcase.inc:349
/home/helmo/src/drupal/drush/tests/drush_testcase.inc:416
/home/helmo/src/drupal/drush/tests/commandTest.php:46
/home/helmo/src/drupal/drush/vendor/phpunit/phpunit/phpunit.php:46

FAILURES!
Tests: 1, Assertions: 2, Failures: 1.

Full results: https://travis-ci.org/helmo/drush/jobs/8499759

Could the --include option that adds /hooks/magic_help_alter be behaving different here?

CommentFileSizeAuthor
#4 drush.test.2030311-Fixed_testUnknownOptions_php_54.patch684 byteshelmo

Comments

helmo’s picture

helmo commented

The line:

// We need to run 'drush cc drush' to clear the commandfile cache; otherwise, our include will not be found.

Should probably removed... as the cc drush code was removed long ago by moshe.

helmo’s picture

helmo commented

I'm really not sure what's happening here... Anyone?

moshe weitzman’s picture

moshe weitzman commented
Status: Active » Postponed (maintainer needs more info)

Anyone available to debug this on php 5.4?

helmo’s picture

helmo commented
Status: Postponed (maintainer needs more info) » Needs review
StatusFileSize
new drush.test.2030311-Fixed_testUnknownOptions_php_54.patch684 bytes

Found it.

It's all green now: https://travis-ci.org/helmo/drush/builds/9202600

moshe weitzman’s picture

moshe weitzman commented
Status: Needs review » Fixed

Committed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.