Convert system module's ValidNumberStepUnitTest to phpunit

woo, looks good thanks:)

This issue was RTBC and passing tests on July 1, the beginning of API freeze.

This increases phpunit test code coverage from

#5: system-validnumber-phpunit-2030173-05.patch queued for re-testing.

That is a really nice test!

+++ b/core/lib/Drupal/Component/Utility/Number.phpundefined
@@ -0,0 +1,60 @@
+    // The fractional part of a double has 53 bits. The greatest number that could
...
+    // $step * 2^53, then dividing by $step will result in a very small remainder.
...
+    // fractional part of a float has 24 bits. That means remainders smaller than

Some lines exceed the 80 chars, so lets fix them.

+++ b/core/tests/Drupal/Tests/Component/Utility/NumberTest.phpundefined
@@ -0,0 +1,125 @@
+class NumberTest extends UnitTestCase {
+  public static function getInfo() {

Lets add an empty line here.

Thank you

+++ b/core/includes/common.incundefined
@@ -628,47 +629,13 @@ function valid_url($url, $absolute = FALSE) {
 /**
  * Verifies that a number is a multiple of a given step.
  *
- * The implementation assumes it is dealing with IEEE 754 double precision
- * floating point numbers that are used by PHP on most systems.
+ * @see \Drupal\Component\Utility\Number::validStep()
  *
- * This is based on the number/range verification methods of webkit.
- *
- * @param $value
- *   The value that needs to be checked.
- * @param $step
- *   The step scale factor. Must be positive.
- * @param $offset
- *   (optional) An offset, to which the difference must be a multiple of the
- *   given step.
- *
- * @return bool
- *   TRUE if no step mismatch has occured, or FALSE otherwise.
- *
- * @see http://opensource.apple.com/source/WebCore/WebCore-1298/html/NumberInputType.cpp
+ * @deprecated as of Drupal 8.0. Use
+ *   \Drupal\Component\Utility\Number::validStep() directly instead
  */
 function valid_number_step($value, $step, $offset = 0.0) {

I'm not sure that we should be removing the documentation of the parameters and return value here... we can remove the the details and replace with the @see...

So I think this should look like this...

+++ b/core/includes/common.incundefined
@@ -628,47 +629,13 @@ function valid_url($url, $absolute = FALSE) {
 /**
  * Verifies that a number is a multiple of a given step.
  *
  * @see \Drupal\Component\Utility\Number::validStep()
  *
  * @param $value
  *   The value that needs to be checked.
  * @param $step
  *   The step scale factor. Must be positive.
  * @param $offset
  *   (optional) An offset, to which the difference must be a multiple of the
  *   given step.
  *
  * @return bool
  *   TRUE if no step mismatch has occured, or FALSE otherwise.
  *
  * @deprecated as of Drupal 8.0. Use
  *   \Drupal\Component\Utility\Number::validStep() directly instead
  */
 function valid_number_step($value, $step, $offset = 0.0) {

... I know I committed a patch by @jhedstrom that removed docs like this is the past but I now consider that a mistake...

oh everyone forgot this issue i guess:P

+++ b/core/tests/Drupal/Tests/Component/Utility/NumberTest.php
@@ -0,0 +1,126 @@
+    $this->assertEquals($return, $expected);
...
+    $this->assertEquals($return, $expected);

$expected should be the first argument

ty

Committed/pushed to 8.x, thanks!