Convert entity_get_bundles to a method on the entity manager [#2030151]

Updated: Comment #10

Problem/Motivation

To help general DX/code organisation bring entity bundle logic into the EntityManager. This will benefit unit testing (mocking etc..) and remove the need for calling a procedural function.

Proposed resolution

Convert entity_get_bundles() function in entity.inc to methods on the EntityManager. Add getBundleInfo() and getAllBundleInfo(), the module handler is already injected into EntityManager so we can use that.

Remaining tasks

None, patch ready.

User interface changes

None

API changes

Deprecate entity_get_bundles() in favour of new methods?

Original report by @dawehner

Comment	File	Size	Author
#8	2030151-8.patch	5 KB	damiankloip
#8	interdiff-2030151-8.txt	1.26 KB	damiankloip
#12	2030151-12.patch	5.15 KB	damiankloip
#12	interdiff-2030151-12.txt	519 bytes	damiankloip
#6	2030151-6.patch	4.28 KB	damiankloip
#4	2030151-4.patch	4.27 KB	damiankloip
#3	2030151-3.patch	811.16 KB	damiankloip
#3	interdiff-2030151-3.txt	2.16 KB	damiankloip
#1	drupal-2030151-1.patch	3.71 KB	dawehner

Comments

Comment #1

dawehner

German

commented 27 June 2013 at 23:27

Status:

Active

» Needs review

Status	File	Size
new	drupal-2030151-1.patch	3.71 KB

There we go.

Comment #2

28 June 2013 at 00:49

Status:

Needs review

» Needs work

The last submitted patch, drupal-2030151-1.patch, failed testing.

Comment #3

damiankloip commented 7 August 2013 at 15:28

Status:

Needs work

» Needs review

Status	File	Size
new	interdiff-2030151-3.txt	2.16 KB
new	2030151-3.patch	811.16 KB

The bundle labels were still using $bundles variable, and we need to clear the bundleInfo static cache when the entity info definitions are cleared.

Comment #4

damiankloip commented 7 August 2013 at 15:40

Status	File	Size
new	2030151-4.patch	4.27 KB

Tim kindly pointed out that I had accidentally included the whole world in the last patch. interdiff is still good!

Comment #5

7 August 2013 at 15:51

Status:

Needs review

» Needs work

The last submitted patch, 2030151-4.patch, failed testing.

Comment #6

damiankloip commented 7 August 2013 at 16:12

Status:

Needs work

» Needs review

Status	File	Size
new	2030151-6.patch	4.28 KB

ok, lets try once more. Interdiff in #3 is still correct.

Comment #7

7 August 2013 at 18:16

Status:

Needs review

» Needs work

The last submitted patch, 2030151-6.patch, failed testing.

Comment #8

damiankloip commented 7 September 2013 at 14:15

Status	File	Size
new	interdiff-2030151-8.txt	1.26 KB
new	2030151-8.patch	5 KB

Forgot about this issue, rerolled and fixed the remaining failures in EntityReferenceAdminTest. Not sure why the current tests failed without this fix though... Using key() to get the bundle after iterating over it will return NULL as there is no current key to return.

Comment #9

dawehner

German

commented 2 September 2013 at 10:57

Status:	Needs work	» Needs review
Issue tags:		+Needs issue summary update

All looks fine beside the missing issue summary.

Comment #10

dawehner

German

commented 2 September 2013 at 15:06

Status:	Needs review	» Reviewed & tested by the community
Issue tags:	-Needs issue summary update

Thank you

Comment #11

alexpott

he/they

English

🇪🇺🌍

commented 7 September 2013 at 09:43

Status:

Reviewed & tested by the community

» Needs work

+++ b/core/includes/entity.inc
@@ -58,33 +57,12 @@ function entity_info_cache_clear() {
  *   The bundle info for a specific entity type, or all entity types.
  */
 function entity_get_bundles($entity_type = NULL) {

I think we need at least an @see here to the new getBundleInfo and getAllBundleInfo methods.