Simple enough, at the moment we are using a bastardised get() method to return the executable object. Let's atleast have a method to deal with this.

CommentFileSizeAuthor
#12 vdc-2029733-12.patch38.72 KBtim.plunkett
#7 2029733-7.patch39.09 KBdamiankloip
#7 interdiff-2029733-7.txt707 bytesdamiankloip
#5 2029733-5.patch38.4 KBdamiankloip
#2 2029733-2.patch38.38 KBdamiankloip
#2 interdiff-2029733-2.txt643 bytesdamiankloip
vdc.getExecutable.patch38.3 KBdamiankloip

Comments

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Needs work 
+++ b/core/modules/views/lib/Drupal/views/Plugin/Core/Entity/View.phpundefined
@@ -120,15 +120,15 @@ class View extends ConfigEntityBase implements ViewStorageInterface {
+   * Gets an executable instance for this view.
...
+  public function getExecutable() {
...
+    if (!isset($this->executable)) {
+      $this->executable = Views::executableFactory()->get($this);
     }

This should @return a ViewExecutable if possible.

damiankloip’s picture

damiankloip commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-2029733-2.txt643 bytes
new 2029733-2.patch38.38 KB

Let's do that.

amateescu’s picture

amateescu commented
Status: Needs review » Reviewed & tested by the community

Looks good to me :)

dawehner’s picture

dawehner
Primary language German
commented

+1 this is a improvement.

damiankloip’s picture

damiankloip commented
StatusFileSize
new 2029733-5.patch38.4 KB

Pure git reroll.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2029733-5.patch, failed testing.

damiankloip’s picture

damiankloip commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-2029733-7.txt707 bytes
new 2029733-7.patch39.09 KB

There was one conversion missing in ViewListController

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Back to RTBC

yesct’s picture

yesct commented
Issue tags: +RTBC July 1

This issue was RTBC and passing tests on July 1, the beginning of API freeze.

damiankloip’s picture

damiankloip commented

#7: 2029733-7.patch queued for re-testing.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work

Needs a reroll...

git ac https://drupal.org/files/2029733-7.patch
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 40024  100 40024    0     0  34676      0  0:00:01  0:00:01 --:--:-- 61012
error: patch failed: core/modules/views_ui/lib/Drupal/views_ui/Form/Ajax/AddItem.php:60
error: core/modules/views_ui/lib/Drupal/views_ui/Form/Ajax/AddItem.php: patch does not apply
error: patch failed: core/modules/views_ui/lib/Drupal/views_ui/Form/Ajax/ConfigItem.php:63
error: core/modules/views_ui/lib/Drupal/views_ui/Form/Ajax/ConfigItem.php: patch does not apply
error: patch failed: core/modules/views_ui/lib/Drupal/views_ui/Form/Ajax/ConfigItemExtra.php:62
error: core/modules/views_ui/lib/Drupal/views_ui/Form/Ajax/ConfigItemExtra.php: patch does not apply
error: patch failed: core/modules/views_ui/lib/Drupal/views_ui/Form/Ajax/Display.php:63
error: core/modules/views_ui/lib/Drupal/views_ui/Form/Ajax/Display.php: patch does not apply
error: patch failed: core/modules/views_ui/lib/Drupal/views_ui/Form/Ajax/Rearrange.php:53
error: core/modules/views_ui/lib/Drupal/views_ui/Form/Ajax/Rearrange.php: patch does not apply
tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs work » Reviewed & tested by the community
StatusFileSize
new vdc-2029733-12.patch38.72 KB

Conflicted with #2032031: [Change notice] Deprecate use of views_get_view function in favour of Views::getView() method.
No actual changes, so marking back to RTBC.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 91fbd4b and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.