We need to convert node_admin_nodes page callback introduced in #1895160: Convert admin/content to a View, keep a non-views fallback with no bulk operations to a new style controller.

See for instructions: http://drupal.org/node/1800686 & https://drupal.org/node/1953346

Files: 
CommentFileSizeAuthor
#12 node-2029569-12.patch1.71 KBtim.plunkett
PASSED: [[SimpleTest]]: [MySQL] 58,355 pass(es). View
#10 2029569-convert-node_admin_nodes-9.patch12.73 KBAjitS
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 2029569-convert-node_admin_nodes-9.patch. Unable to apply patch. See the log in the details link for more information. View
#5 2029569-convert-node_admin_nodes-5.patch12.73 KBAjitS
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 2029569-convert-node_admin_nodes-5.patch. Unable to apply patch. See the log in the details link for more information. View
#4 2029569-convert-node_admin_nodes-4.patch0 bytesAjitS
FAILED: [[SimpleTest]]: [MySQL] 56,354 pass(es), 11 fail(s), and 21 exception(s). View

Comments

pcambra’s picture

Issue tags: +MENU_LOCAL_ACTION

Adding tag

tim.plunkett’s picture

Just a heads up, you're going to hit the same problems as #1938884: Replace the fallback user listing with a list controller

AjitS’s picture

Assigned: Unassigned » AjitS

Assigning to myself. Will try to roll out a patch soon.

AjitS’s picture

Status: Active » Needs review
FileSize
0 bytes
FAILED: [[SimpleTest]]: [MySQL] 56,354 pass(es), 11 fail(s), and 21 exception(s). View

Patch attached. Keeping this assigned to me. Willing to make changes as per the feedback.

AjitS’s picture

FileSize
12.73 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 2029569-convert-node_admin_nodes-5.patch. Unable to apply patch. See the log in the details link for more information. View

Oops, wrong patch.

Status: Needs review » Needs work

The last submitted patch, 2029569-convert-node_admin_nodes-5.patch, failed testing.

tim.plunkett’s picture

I think the patch was backwards? Also I just realized this is essentially a duplicate of #2021161: Replace the fallback node listing with a list controller...

tim.plunkett’s picture

Except that doesn't support paging? Idk what to do here.

pcambra’s picture

Status: Needs work » Closed (duplicate)

Sorry about that @tim.plunkett I searched for node_admin_nodes and didn't find anything.

Agreed, the patch in #5 is kind of weird as it's undoing something is not done yet (?)

Marking this as dupe, @AjitS, please start from #2021161: Replace the fallback node listing with a list controller

AjitS’s picture

Status: Closed (duplicate) » Needs work
FileSize
12.73 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 2029569-convert-node_admin_nodes-9.patch. Unable to apply patch. See the log in the details link for more information. View

Re-rolling the patch from #5.

AjitS’s picture

Status: Needs work » Closed (duplicate)

Sorry, was working on the re-roll. Didn't realize this was closed. Should have refreshed to page before submitting the patch.

tim.plunkett’s picture

Assigned: AjitS » tim.plunkett
Priority: Normal » Major
Status: Closed (duplicate) » Needs work
FileSize
1.71 KB
PASSED: [[SimpleTest]]: [MySQL] 58,355 pass(es). View

Reopening this for "Phase 1", and leaving the other issue for removing node_admin_nodes() properly.

This will fail until #2027115: Allow views to override existing routing items is committed, will mark "needs review" when that happens.

tim.plunkett’s picture

Status: Needs work » Needs review
disasm’s picture

Status: Needs review » Reviewed & tested by the community

#2027115: Allow views to override existing routing items is in. This is simple, don't see any issues. Marking RTBC.

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Dieeeeee!

Committed and pushed to 8.x. :D

tim.plunkett’s picture

Assigned: tim.plunkett » Unassigned

Woot

Automatically closed -- issue fixed for 2 weeks with no activity.

xjm’s picture

Component: node.module » node system
Issue summary: View changes