It's kind of silly to have one file with one function it, really.

Plus, this will/should probably get converted at some point anyway by the twig team.

CommentFileSizeAuthor
#4 field-ui-2029357-4.patch2.09 KBtim.plunkett
#1 2029357-1-kill-field-ui-admin.inc_.patch6.13 KBswentel

Comments

swentel’s picture

swentel commented
Status: Active » Needs review
StatusFileSize
new 2029357-1-kill-field-ui-admin.inc_.patch6.13 KB
pcambra’s picture

pcambra
he/him
Primary language Spanish
commented
Status: Needs review » Reviewed & tested by the community

Agreed, this is just moving the code back to the ui module

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to 8.x. Thanks.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Fixed » Needs review
StatusFileSize
new field-ui-2029357-4.patch2.09 KB

Let's also stop including it then :)

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Reviewed & tested by the community

Sure! noting to include :)

core8$ git grep field_ui.admin
core/modules/field_ui/field_ui.module:      drupal_get_path('module', 'field_ui') . '/css/field_ui.admin.css' => array(),
core/modules/field_ui/lib/Drupal/field_ui/Form/FieldDeleteForm.php:    form_load_include($form_state, 'inc', 'field_ui', 'field_ui.admin');
core/modules/field_ui/lib/Drupal/field_ui/Form/FieldEditForm.php:    form_load_include($form_state, 'inc', 'field_ui', 'field_ui.admin');
core/modules/field_ui/lib/Drupal/field_ui/Form/FieldInstanceFormBase.php:    form_load_include($form_state, 'inc', 'field_ui', 'field_ui.admin');
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 9144713 and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.