Node revisions don't work. That is not an exaggeration. Try this simple test under a HEAD installation: create a node with the "create new revision" checkbox checked. Then edit it, with the "create new revision" checkbox checked. Then, go to the revisions page and try to view the old revision. It doesn't work: instead, the new revision is displayed. This is a critical error as Drupal 6 cannot be released with node revisions in this state.
I have double checked this on a clean HEAD install, same thing happens.
I believe the error is in this line:
<?php
$items['node/%node/revisions/%/view'] = array(
'title' => 'Revisions',
'page callback' => 'node_show',
'page arguments' => array(1, NULL, TRUE),
'type' => MENU_CALLBACK,
);
?>
It should be something like:
<?php
$items['node/%node/revisions/%/view'] = array(
'title' => 'Revisions',
'load arguments' => array(3),
'page callback' => 'node_show',
'page arguments' => array(1, NULL, TRUE),
'type' => MENU_CALLBACK,
);
?>
However, I'm hardly an expert at the menu system, so this could turn out to be completely the wrong solution. In any case, however, something is going wrong in the loading of the older revision of the node. Whatever the cause, this certainly needs to be fixed.
Comment | File | Size | Author |
---|---|---|---|
#1 | node_revisions.patch | 610 bytes | theborg |
Comments
Comment #1
theborg CreditAttribution: theborg commentedGood catch!
Tested: added, deleted and reverted revisions and it works ok.
Patch provided.
Comment #2
theborg CreditAttribution: theborg commentedComment #3
catchTested, works. RTBC.
Comment #4
Gábor HojtsyWell, the issue at hand seems to be that the view page for node a revision is not displaying that node revision, not that revisions do not work :)
Comment #5
chx CreditAttribution: chx commentedPatch is indeed RTBC I have no idea how this happened :(
Comment #6
catchAll my revisions testing the other patch were variations on agagagagag - so I simply didn't notice they were actually the same when looking at old ones.
Comment #7
Gábor HojtsyThanks, committed.
Comment #8
(not verified) CreditAttribution: commentedAutomatically closed -- issue fixed for two weeks with no activity.