drupal_add_css() and drupal_add_js() should both be marked deprecated. If the functions survive 8.0 they'll only be used internally if we're going to support render caching at all.

I'd like to mark drupal_set_title() and others deprecated as well, but that doesn't have an exact equivalent for all cases yet so not sure if we can get away with that.

CommentFileSizeAuthor
#3 2028415-drupal_add_deprecated.patch847 bytescameron tod

Comments

andypost’s picture

andypost
he/him
Primary language Russian
commented

So what the explanation needs to be written after @deprecated ?

catch’s picture

catch
he/him
Primary language English
commented

Use #attached instead.

cameron tod’s picture

cameron tod commented
Status: Active » Needs review
StatusFileSize
new 2028415-drupal_add_deprecated.patch847 bytes

Here we go.

Crell’s picture

Crell commented
Status: Needs review » Reviewed & tested by the community

Looks god.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to 8.x. Thanks.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Just for future reference: this was spun off from #1839338-23: [meta] Remove drupal_set_*() drupal_add_*() in favour of #attached/response for out-of-band stuff.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.