There is an issue #1957142: Replace config() with Drupal::config() to replace all calls to config() with Drupal::config(). However this is unlikely to be implemented until code freeze, therefore config() should be deprecated in the meantime.

CommentFileSizeAuthor
#9 config_deprecate_config-2028149-9.patch723 byteseli-t
#3 config_deprecate_config-2028149-3.patch675 byteseli-t
#1 config_deprecate_config-2028149-1.patch675 byteseli-t

Comments

eli-t’s picture

eli-t
he/him
Primary language English
Location Manchester
commented
Status: Active » Needs review
StatusFileSize
new config_deprecate_config-2028149-1.patch675 bytes
damiankloip’s picture

damiankloip commented
Status: Needs review » Needs work

Nice, i agree that we should mark this @deprecated and then deal with #1957142: Replace config() with Drupal::config(). Although I still don't see the point in making lots of issues out of that but hey, not a problem here :)

+++ b/core/includes/config.incundefined
@@ -72,6 +72,9 @@ function config_get_storage_names_with_prefix($prefix = '') {
+ * @deprecated This function has been replaced by the \Drupal::config function.

add parenthesis to config(), and we should use 'method' and not 'function'

eli-t’s picture

eli-t
he/him
Primary language English
Location Manchester
commented
Status: Needs work » Needs review
StatusFileSize
new config_deprecate_config-2028149-3.patch675 bytes

Changes suggested in #2 implemented.

damiankloip’s picture

damiankloip commented
Assigned: eli-t » Unassigned
Status: Needs review » Reviewed & tested by the community

Thank you. Looks good to me.

Status: Reviewed & tested by the community » Needs work
Issue tags: -Novice

The last submitted patch, config_deprecate_config-2028149-3.patch, failed testing.

eli-t’s picture

eli-t
he/him
Primary language English
Location Manchester
commented
Status: Needs work » Needs review
Issue tags: +Novice

#3: config_deprecate_config-2028149-3.patch queued for re-testing.

eli-t’s picture

eli-t
he/him
Primary language English
Location Manchester
commented
Status: Needs review » Reviewed & tested by the community

Returning to rtbc following successful retest with no code changes.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work

Need to add the version info see https://drupal.org/coding-standards/docs#deprecated

eli-t’s picture

eli-t
he/him
Primary language English
Location Manchester
commented
Status: Needs work » Needs review
StatusFileSize
new config_deprecate_config-2028149-9.patch723 bytes

Added Drupal 8.0 as version at which the function was deprecated and added @see block to the replacement.

damiankloip’s picture

damiankloip commented
Status: Needs review » Reviewed & tested by the community

Lookin' good

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to 8.x. Thanks.

Automatically closed -- issue fixed for 2 weeks with no activity.