For some reasons drupal_get_path_alias() get removed without all its users.

Comments

dawehner’s picture

Status: Active » Needs review
Issue tags: +PHPUnit, +VDC
StatusFileSize
new5.79 KB

Fixed it with an additional unit test.

ParisLiakos’s picture

Closed #2011926: Raw::get_argument() calls dead drupal_get_path_alias() as dupe since there was no patch there:)

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/argument_default/Raw.phpundefined
@@ -22,6 +25,50 @@
+    return new static($configuration, $plugin_id, $plugin_definition,
+      $container->get('request'), $container->get('path.alias_manager.cached')
+    );

this looks ugly:) either put it in one line, or seperate line per argument?

dawehner’s picture

StatusFileSize
new960 bytes
new5.82 KB

I so much don't care.

damiankloip’s picture

Status: Needs review » Reviewed & tested by the community

Fix looks good, and the tests look great!

ParisLiakos’s picture

StatusFileSize
new660 bytes
new5.81 KB

i am sorry, i just couldnt let this go:P

damiankloip’s picture

+1, I totally didn't notice that! :)

Status: Reviewed & tested by the community » Needs work
Issue tags: -PHPUnit, -VDC

The last submitted patch, vdc-2028145-5.patch, failed testing.

ParisLiakos’s picture

Status: Needs work » Needs review
Issue tags: +PHPUnit, +VDC

#5: vdc-2028145-5.patch queued for re-testing.

dawehner’s picture

Status: Needs review » Reviewed & tested by the community

So this was just a random failure?

ParisLiakos’s picture

yeah, i am seeing some taxonomy ones that i havent see again:/

dries’s picture

Status: Reviewed & tested by the community » Fixed

Committed to 8.x. Thanks.

Automatically closed -- issue fixed for 2 weeks with no activity.