Add typographic styles, components, and utility classes

Updated issue summary.

Updated #3, which no longer applied.

Additionally, because Drupal 8 isn't supporting IE8, I don't think we need the pixel fallbacks for rems, so I didn't include them.

There might be more we want to do, but I at least wanted to get this applying to HEAD.

Tagging with the global sprint.

I'm going to review this patch.

I'm not sure how to test this. I've updated the summary to include the template and included some possible follow up actions.

5: drupal-seven-type-2028053-5.patch queued for re-testing.

I don't understand why changing some CSS definitions would cause this test to fail -- it appears to be testing whether the CSS stylesheets exist and are in the right place. Maybe someone else could take a look.

Hm, let's see...

Ah, of course. Thanks.

Updating in preparation for DrupalCon Austin sprints. See http://www.hook42.com/blog/prepping-drupalcon-austin-sprints-sprint-lead....

#15 does not apply to HEAD and needs a reroll.

Forgot the status, sorry.

Working on this to re-roll.

rerolled patch attached

Reroll looks good. Great work vegantriathlete. Only remaining issue is adding the text-transform: uppercase from #17.

Will add changes as requested.

New patch and interdiff attached.

I had a look at that issue and I don't fully understand what you mean in the first part of #2028053-26: Add typographic styles, components, and utility classes:

+++ b/core/themes/seven/seven.base.css
@@ -37,20 +37,26 @@ h6 {
 h1 {
-  font-size: 1.538em;
+  font-size: 1.25rem;
 }
 h2 {
-  font-size: 1.385em;
+  font-size: 1.125rem;
 }

The h1 and h2 tags have different sizes: 1.25 and 1.125. I think that's correct. Is there any issue here?

I think I fixed all the remaining reported problems from the issue summary. This is my first contribution, so be benevolent :)

Let me know if there is something wrong.

franxo, thanks for contributing!

I think this happened further upthread, but the pixel fallback values seem to have reappeared. As I said in #5, as D8 isn't supporting IE8, I don't think these values are necessary any longer, and they should be removed. Lewis, what do you think?

Here is a new patch with a smaller scope. Unfortunately I can't provide an interdiff file, because the old patch cant be applied anymore and I was not able to make patchutils work on my machine…

I'm going to add screenshots a little bit later…

I'm not sure what kind of screenshots would be most helpful here, but from what I can tell this doesn't change the look of anything (which is the idea).

I had trouble finding admin pages with any header elements other than the title, but here's the available updates page, without the patch and with the patch:

And here's a sample page, with the theme set to Seven, without and with the patch:

Thamas are you still working on this? If not we should unassign it for the sprints tomorrow.

Leaving screenshots needed tag in case there's something more we want to see.

Unassigning so others can work on reviewing this today.

The issue summary and the patch do not match. Either the patch needs work to address everything listed in the summary or we need to update the summary.

1. +++ b/core/themes/seven/css/base/typography.css
   @@ -0,0 +1,36 @@
   +* Reuseable utility classes that applies vertical spacing consistency
   

   s/applies/apply/

2. +++ b/core/themes/seven/css/base/typography.css
   @@ -0,0 +1,36 @@
   +* and inline with the base line height of Seven.
   

   s/inline/in line/

Committed 93c6556 and pushed to 8.0.x. Thanks!

diff --git a/core/themes/seven/css/base/typography.css b/core/themes/seven/css/base/typography.css
index 1883adf..fd8e8eb 100644
--- a/core/themes/seven/css/base/typography.css
+++ b/core/themes/seven/css/base/typography.css
@@ -1,6 +1,6 @@
 /**
-* Reuseable utility classes that applies vertical spacing consistency
-* and inline with the base line height of Seven.
+* Reusable utility classes that apply vertical spacing consistency and in line
+* with the base line height of Seven.
 */
 .leader {
   margin-top: 20px;

Fixed #44 on commit and also the spelling of reusable.