There are two Php.php files inside Views module (argument validator/default) that must be moved under the php module.

  1. git move (see https://drupal.org/documentation/git/configure renames = copies) the file
  2. change namespace appropriately
  3. add the relevant use Drupal\views\Plugin\views\argument_validator\ArgumentValidatorPluginBase / argument_default\ArgumentDefaultPluginBase statements.
CommentFileSizeAuthor
#3 move-diff.txt5.42 KBdawehner
#3 interdiff.txt3.05 KBdawehner
#3 vdc-2028041-2.patch5.63 KBdawehner
#1 php_arguments-2028041-1.patch12 KBplopesc

Comments

plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
Status: Active » Needs review
StatusFileSize
new php_arguments-2028041-1.patch12 KB

Hello

Attaching patch that moves PHP default argument and argument validator to PHP module.

Regards

chx’s picture

chx commented
Status: Needs review » Reviewed & tested by the community

Very nice job, separating out the test like that.

Put all the rats in one trap, said Gandalf; and I will.

With this patch, all evals are now inside the PHP module.

dawehner’s picture

dawehner
Primary language German
commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new vdc-2028041-2.patch5.63 KB
new interdiff.txt3.05 KB
new move-diff.txt5.42 KB

It is a perfect idea to move this functionality to the php module.

Here is also a move diff, as it is way easier to review, so no credit please.

Additional there are some fixes involved which seemed to be required to get this change in.

chx’s picture

chx commented
Status: Needs review » Reviewed & tested by the community

Oh sure, thanks for fixing it up. (Although I still object fixing Contains vs Definition piecemeal, it needs to be done in one go, but as long as it doesnt block a patch why not.)

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed a5c9398 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.