Expand ItemInterface (aggregator.module) with methods

Thanks for working on this, looks good, just a few minor things and one method rename.

1. +++ b/core/modules/aggregator/aggregator.pages.inc
   @@ -151,21 +151,21 @@ function theme_aggregator_summary_item($variables) {
    
   ...
   +  if (isset($item->ftitle) && $item->getFid() != null) {
   +    $variables['source_url'] = url("aggregator/sources/$item->getFid()");
   

   method calls in code don't work, you could add {} around it, but I prefer '...' . $item->getFid().

2. +++ b/core/modules/aggregator/lib/Drupal/aggregator/ItemInterface.php
   @@ -14,4 +14,135 @@
   +   * Returns the feed  id of aggregator item.
   

   Additional space in here.

3. +++ b/core/modules/aggregator/lib/Drupal/aggregator/ItemInterface.php
   @@ -14,4 +14,135 @@
   +  public function getFid();
   ...
   +  public function setFid($fid);
   

   Let's do getFeedId() and setFeedId() instead, which is much more self-explaining.

4. +++ b/core/modules/aggregator/lib/Drupal/aggregator/ItemInterface.php
   @@ -14,4 +14,135 @@
   +   * @param int $fid
   +   *   The feed id
   +   * @return \Drupal\aggregator\ItemInterface
   +   *   The called feed item entity.
   

   there needs to be an empty line between @param and @return.

5. +++ b/core/modules/aggregator/lib/Drupal/aggregator/ItemInterface.php
   @@ -14,4 +14,135 @@
   +  public function  getLink();
   

   Another double space.

1. +++ b/core/modules/aggregator/aggregator.pages.inc
   @@ -78,21 +78,21 @@ function theme_aggregator_summary_item($variables) {
   +  if (isset($item->ftitle) && $item->getFid() != null) {
   +    $variables['source_url'] = url('aggregator/sources/' . $item->getFid());
   
   +++ b/core/modules/aggregator/lib/Drupal/aggregator/ItemStorageController.php
   @@ -50,7 +50,7 @@ public function deleteCategories(array $entities) {
   +    $result = $this->database->query('SELECT cid FROM {aggregator_category_feed} WHERE fid = :fid', array(':fid' => $item->getFid()));
   
   +++ b/core/modules/aggregator/lib/Drupal/aggregator/Plugin/aggregator/processor/DefaultProcessor.php
   @@ -171,17 +171,17 @@ public function process(Feed $feed) {
   +      $entry->setFid($feed->id());
   +      $entry->setLink($item['link']);
   

   Those calls should now use FeedId() instead of Fid()

2. +++ b/core/modules/aggregator/lib/Drupal/aggregator/ItemInterface.php
   @@ -14,4 +14,136 @@
   +  public function setTitle($title);
   +
   +
   +  /**
   

   two empty lines here.

3. +++ b/core/modules/aggregator/lib/Drupal/aggregator/ItemInterface.php
   @@ -14,4 +14,136 @@
   +  public function setAuthor($author);
   +
   +
   +  /**
   

   same here.

Thanks, looks good to me!

#15: core-aggregator_item_properties-2028039-15.patch queued for re-testing.

We don't enforce that the methods are used and we already have a general change notice that base fields now have methods that should be used: https://drupal.org/node/1806650. I don't think we need to reference every single issue that adds them, added the meta issue..