The hideErrordiv in the clientside_validation.js script is overzealous. In zen at least (not sure about other themes), a single error message is not written as an unordered list, as a result intializing this hides a single server side error.

It would seem more prudent to only look for messages that this module is responsible for managing. The attached patch scopes the selector to just look at clientside validation error message divs. Works for me in light testing on Chrome only.

CommentFileSizeAuthor
clientside-validation-hides-errors.patch654 bytesfearlsgroove

Comments

attiks’s picture

attiks commented

Thanks for the patch, but I think we should leave the messages class on it, so the styling stays the same. The removing should be done using the new class.

I'll try to reroll and commit this asap, if you can reroll it that would be great.

fearlsgroove’s picture

fearlsgroove commented

This patch doesn't change any markup, just the selector used to hide "empty" error messages. Styling should look exactly the same before and after.

jelle_s’s picture

jelle_s
Primary language Dutch
Location Antwerp, Belgium
commented
Status: Needs review » Fixed

Fixed in the latest dev version. Thanks for the patch!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.