Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Hi,
Recently noticed that variable filter_allowed_protocols meets twice in code, but with different default values (see drupal_strip_dangerous_protocols() and _filter_url()). In the second function missing tel protocol.
I think that this protocol should be supported. Moreover, sequence of tags in default value should be the same. So I attached a patch that solves this issue.
| Comment | File | Size | Author |
|---|---|---|---|
| drupal-different-default-values-for-filter_allowed_protocols-variable.patch | 835 bytes | Spleshka | |
Comments
Comment #2
Spleshkadrupal-different-default-values-for-filter_allowed_protocols-variable.patch queued for re-testing.
Comment #3
dpovshed CreditAttribution: dpovshed commentedThanks @Spleshka, the patch looks fine.
The fix is small and accurate, I think we can proceed with this code clearance.
Comment #4
SpleshkaDoes it look like RTBC ? :)
Comment #5
dpovshed CreditAttribution: dpovshed commentedYep, updating status.
Comment #6
SpleshkaAny updates here? Patch seems to be obvious.
Comment #7
SpleshkaStill no progress?
Comment #8
andypost+1 to commit
Comment #9
David_Rothstein CreditAttribution: David_Rothstein commentedThanks; this looks like the previously un-filed followup to #945332: Allow "tel:" protocol through drupal_strip_dangerous_protocols.
Drupal 8 actually lost support for 'tel' entirely so we should have an issue for that, but I suppose that doesn't stop fixing the inconsistency in Drupal 7.
Committed to 7.x - thanks! http://drupalcode.org/project/drupal.git/commit/705eb17
Comment #10
David_Rothstein CreditAttribution: David_Rothstein commentedFiled the Drupal 8 issue here: #2058435: Drupal 8 lost support for the 'tel' protocol in URL filtering functions