Hi,

Recently noticed that variable filter_allowed_protocols meets twice in code, but with different default values (see drupal_strip_dangerous_protocols() and _filter_url()). In the second function missing tel protocol.

I think that this protocol should be supported. Moreover, sequence of tags in default value should be the same. So I attached a patch that solves this issue.

CommentFileSizeAuthor
drupal-different-default-values-for-filter_allowed_protocols-variable.patch835 bytesspleshka

Comments

Status: Needs review » Needs work

The last submitted patch, drupal-different-default-values-for-filter_allowed_protocols-variable.patch, failed testing.

spleshka’s picture

spleshka
he/him
Primary language English
Location UAE
commented
Status: Needs work » Needs review

drupal-different-default-values-for-filter_allowed_protocols-variable.patch queued for re-testing.

dpovshed’s picture

dpovshed commented

Thanks @Spleshka, the patch looks fine.
The fix is small and accurate, I think we can proceed with this code clearance.

spleshka’s picture

spleshka
he/him
Primary language English
Location UAE
commented

Does it look like RTBC ? :)

dpovshed’s picture

dpovshed commented
Status: Needs review » Reviewed & tested by the community

Yep, updating status.

spleshka’s picture

spleshka
he/him
Primary language English
Location UAE
commented

Any updates here? Patch seems to be obvious.

spleshka’s picture

spleshka
he/him
Primary language English
Location UAE
commented

Still no progress?

andypost’s picture

andypost
he/him
Primary language Russian
commented

+1 to commit

David_Rothstein’s picture

David_Rothstein commented
Status: Reviewed & tested by the community » Fixed
Issue tags: +7.23 release notes

Thanks; this looks like the previously un-filed followup to #945332: Allow "tel:" protocol through drupal_strip_dangerous_protocols.

Drupal 8 actually lost support for 'tel' entirely so we should have an issue for that, but I suppose that doesn't stop fixing the inconsistency in Drupal 7.

Committed to 7.x - thanks! http://drupalcode.org/project/drupal.git/commit/705eb17

David_Rothstein’s picture

David_Rothstein commented

Filed the Drupal 8 issue here: #2058435: Drupal 8 lost support for the 'tel' protocol in URL filtering functions

Automatically closed -- issue fixed for 2 weeks with no activity.