Hi,

Recently noticed that user_pictures variable has wrong default value in UserController:attachLoad(). By default this variable is set to 0, but this method uses 1 instead.

Patch that fixes that bug attached.

CommentFileSizeAuthor
drupal-wrong-default-value-for-user-pictures-variable.patch637 bytesspleshka

Comments

Status: Needs review » Needs work

The last submitted patch, drupal-wrong-default-value-for-user-pictures-variable.patch, failed testing.

spleshka’s picture

spleshka
he/him
Primary language English
Location UAE
commented
Status: Needs work » Needs review

drupal-wrong-default-value-for-user-pictures-variable.patch queued for re-testing.

droplet’s picture

droplet commented
Status: Needs review » Reviewed & tested by the community

D8 no this issue. Above patch seems correct.

spleshka’s picture

spleshka
he/him
Primary language English
Location UAE
commented

Any updates here? Patch seems to be obvious.

spleshka’s picture

spleshka
he/him
Primary language English
Location UAE
commented

Still no progress here?

David_Rothstein’s picture

David_Rothstein commented
Status: Reviewed & tested by the community » Fixed

Committed to 7.x - thanks! http://drupalcode.org/project/drupal.git/commit/eb13c0c

spleshka’s picture

spleshka
he/him
Primary language English
Location UAE
commented

Great, thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.