Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.We now have the ability to detect legacy routes directly rather than indirectly. So let's do that.
As a side effect, this means that new-style controllers can call functions, not just classed methods. (That's still not recommended, but it will now work.)
Patch as soon as I have a nid.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | 2026037-legacy-check.patch | 1.16 KB | Crell |
| #1 | 2026037-legacy-check.patch | 1.16 KB | Crell |
Comments
Comment #1
Crell CreditAttribution: Crell commentedComment #3
Crell CreditAttribution: Crell commentedChasing HEAD. I tried 3 of the failing tests and all of them passed for me locally. I don't know why. My best guess is testbot is on 5.3 and I'm on 5.4, but I'd expect the issue to be the other way around, then.
(No interdiff; it's a one character change in a tiny patch.)
Comment #4
Crell CreditAttribution: Crell commentedTagging.
Comment #5
dawehnerThe patch looks pretty perfect. Hopefully we are able to convert all of the callbacks in a reasonable amount of time, so we can get rid of the legacy related functionality.
Comment #6
webchickActually, I love this quite a lot. Since Symfony allows whatever callable, it makes sense for us to do it too, and It's a good emergency stopgap if converting things to controllers is the last critical issue holding up RC1; we could simply script conversion of the rest to point at their callback functions.
Committed and pushed to 8.x. Thanks!