This function bypasses the entity API, so let's convert it to entity_query.

CommentFileSizeAuthor
#6 user-2024985-6.patch3.88 KBtim.plunkett
#1 user-2024985-1.patch3.96 KBtim.plunkett

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Active » Needs review
StatusFileSize
new user-2024985-1.patch3.96 KB

When converting admin/people to a view, it seems I left this in by mistake.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Reviewed & tested by the community

As discussed in IRC, we'll still need EFQ support for the user roles, which I expected to be added here but as this is just dead code, let's remove it.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Title: Convert user_build_filter_query to entity_query » Remove obsolete user_build_filter_query
catch’s picture

catch
he/him
Primary language English
commented

#1: user-2024985-1.patch queued for re-testing.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, user-2024985-1.patch, failed testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs work » Reviewed & tested by the community
StatusFileSize
new user-2024985-6.patch3.88 KB

The code I was deleting was changed. It's still being 100% deleted.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Thanks for the re-roll. Committed/pushed to 8.x, thanks!

Is there an issue open for EFQ roles support?

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

I guess we can use #1751274: Do not query user_roles directly for that?

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.