Since there is nothing in core that uses theme_meter, I propose we remove it from core. If poll module needs it, then we should move it into poll module.

Related

#1939088: Convert theme_meter() to Twig

CommentFileSizeAuthor
#1 drupal-remove_theme_meter-2024681.patch2.67 KBjenlampton

Comments

jenlampton’s picture

jenlampton
she / her
commented
Status: Active » Needs review
StatusFileSize
new drupal-remove_theme_meter-2024681.patch2.67 KB

patch.

jenlampton’s picture

jenlampton
she / her
commented
Issue tags: +Novice

also tagging

Status: Needs review » Needs work
Issue tags: -Novice, -theme system cleanup

The last submitted patch, drupal-remove_theme_meter-2024681.patch, failed testing.

star-szr’s picture

star-szr
he/him
Primary language English
commented
Status: Needs work » Needs review
Issue tags: +Novice, +theme system cleanup

#1: drupal-remove_theme_meter-2024681.patch queued for re-testing.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Issue tags: +Needs change record

Looks good, does this need a change notice?

sbudker1’s picture

sbudker1 commented
Issue tags: -Needs change record

Clicked around drupal and found nothing unusual everything seemed normal! Good patch jen! jen ++ quicksketch ++

sbudker1’s picture

sbudker1 commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs change record
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

I don't think a change notice is helpful here, this was never in a stable release, so moving straight to fixed.

star-szr’s picture

star-szr
he/him
Primary language English
commented
Issue tags: -Needs change record

Makes sense, removing tag.

Automatically closed -- issue fixed for 2 weeks with no activity.