Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Not alot of explaining needed, convert this test from a DrupalUnitTest to a PHPUnit test. I think it makes sense to use data providers too.
Comment | File | Size | Author |
---|---|---|---|
#3 | 2023095-3.patch | 7.47 KB | damiankloip |
#3 | interdiff-2023095-3.txt | 1.54 KB | damiankloip |
#1 | 2023095-1.patch | 6.84 KB | damiankloip |
#1 | interdiff-2023095-1.txt | 1.8 KB | damiankloip |
vdc-pluginBaseTest-PHPUnit.patch | 6.84 KB | damiankloip | |
Comments
Comment #1
damiankloip CreditAttribution: damiankloip commentedI spoke to dawehner on IRC, the provider methods should be called provider* and not *provider.
Comment #2
dawehnerReally nice! Here are just two nitpicks.
Let's inheritdoc the setup method.
It would be cool to document these methods.
Comment #3
damiankloip CreditAttribution: damiankloip commentedThanks! added that docblock and docs.
Comment #4
dawehnerThank you
Comment #5
alexpottCommitted 893ae86 and pushed to 8.x. Thanks!
Comment #6
andypostneeds follow-up to remove space after $this->
Comment #8
bdone CreditAttribution: bdone commented#2046845: remove space after $this-> testHelperPlugin adds follow-up to remove trailing space in PluginBaseTest