Choose language(done) should be Choose language (done) for example.

CommentFileSizeAuthor
#6 space-inside-span-2022233-6.patch603 bytesstephaneq
#1 fix-missing-spaces-2022233-1.patch603 bytesstephaneq

Comments

stephaneq’s picture

stephaneq
Primary language French
Location Paris 🇫🇷
commented
Status: Active » Needs review
StatusFileSize
new fix-missing-spaces-2022233-1.patch603 bytes

Here is my first patch, hope I did it correctly

thedavidmeister’s picture

thedavidmeister commented

hmm, maybe the space should go inside the "visually-hidden" span rather than before it, what do you think?

stephaneq’s picture

stephaneq
Primary language French
Location Paris 🇫🇷
commented

Inside or outside the span, browsers render it the same way, so I thought it was cleaner to put it outside.

Tell me if I'm wrong, I'll resend the patch.

webflo’s picture

webflo commented
Status: Needs review » Reviewed & tested by the community

I think this is okay.

thedavidmeister’s picture

thedavidmeister commented

#3 it renders differently if the span is hidden with CSS

stephaneq’s picture

stephaneq
Primary language French
Location Paris 🇫🇷
commented
StatusFileSize
new space-inside-span-2022233-6.patch603 bytes

Ok, so let's put it inside the span

thedavidmeister’s picture

thedavidmeister commented

#6 looks good to me.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 972bdf1 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.