Make something amazing, for anyone, at DrupalCon. Standard prices end on August 26.
Choose language(done) should be Choose language (done) for example.
Choose language (done)
Here is my first patch, hope I did it correctly
hmm, maybe the space should go inside the "visually-hidden" span rather than before it, what do you think?
Inside or outside the span, browsers render it the same way, so I thought it was cleaner to put it outside.
Tell me if I'm wrong, I'll resend the patch.
I think this is okay.
#3 it renders differently if the span is hidden with CSS
Ok, so let's put it inside the span
#6 looks good to me.
Committed 972bdf1 and pushed to 8.x. Thanks!
Automatically closed -- issue fixed for 2 weeks with no activity.
Drupal is a registered trademark of Dries Buytaert.