Add module owner to plugin definition in AnnotatedClassDiscovery

Yes! I think this is immensly useful :)

Been saying we should do this for a while now. Big ++ from me. The only problem is that this should be done to Drupal/Core/Plugin/Discovery/AnnotatedClassDiscovery, not the Component class.

Eclipse

if 6 passes, I'm totally RTBC

Eclipse

Yep, I think it's only fair to not override this property if the plugin annotation already provides it.

+1, nice regex

Committed 0360c07 and pushed to 8.x. Thanks!

Hmm.. this doesn't make very much sense for plugins provided by Drupal/Core. Couldn't we have gone with something generic like 'owner' or 'provider'?

Well if Drupal/Core can't provide plugins then that's certainly a regression: #1828616: AnnotatedClassDiscovery is not finding plugins in Drupal\(Core|Component)\COMPONENT_NAME\Plugin directory :-)

#1821846: Consider better naming conventions for plugin types owned by includes doesn't seem like it's going anywhere lately, but I still think this particular bit is unnecessary.

$plugin['module'] == 'Core' // WTF??

$plugin['owner'] == 'Core'
$plugin['owner'] == 'node' // makes sense, IMO

Yay, thanks for the quick turnaround. I hadn't found the validation constraint plugins myself, but thanks for digging that up.

Assuming this is green, it's RTBC.

Seems somewhat pedantic to me, but I'm also not really opposed so++

We should probably file followups to remove the module annotation from as many plugins as possible now in favor of owner.

Eclipse

Is "owner" the right word here? Usually we use that to refer to users. What about "provider" instead?

Usually we use that to refer to users.

Specifically, that's the only way the term is used in HEAD. Well, except for in the theme system, where it's used to refer to a file, but that's a separate thing we might want to fix in a different issue.

"owner" does have history as referring to a module name in CTools and I think some D8 CMI issues, but not in any HEAD code. Given that, I agree with #19's suggestion of 'provider'. Or if someone has other naming ideas, lets consider them.

+++ b/core/lib/Drupal/Core/Plugin/Discovery/AnnotatedClassDiscovery.phpundefined
@@ -69,27 +69,27 @@ public function getDefinitions() {
+   *   The namespace to extract the owner from.

I guess this string should also refer to provider.

Committed e865959 and pushed to 8.x. Thanks!