Fix typo in views schema

Files: 
CommentFileSizeAuthor
#6 2021173-lable-label-fix-6.patch2.81 KBYesCT
PASSED: [[SimpleTest]]: [MySQL] 58,124 pass(es). View
#6 interdiff-3-6.txt2.78 KBYesCT
#3 2021173-lable-label-fix-2.patch2.83 KBvijaycs85
PASSED: [[SimpleTest]]: [MySQL] 58,497 pass(es). View
views-schema-typo-fix.patch1.13 KBvijaycs85
FAILED: [[SimpleTest]]: [MySQL] 57,493 pass(es), 1 fail(s), and 0 exception(s). View

Comments

YesCT’s picture

YesCT’s picture

Status: Needs review » Needs work
Issue tags: +Quick fix, +D8MI, +VDC, +views configuration schema

ag " lable" core

shows that those are the only 3 lable* typos in schemas.

--
I see other typos from that issue:
+ label: 'The title which will be overriden for the page'

I think overriden is overridden
I wonder what the label actually says.

+ label: 'IN operartor'
operator
+ label: 'Seprator'
Separator

If the typos are in the UI, .. we can leave them there (but fix both the UI and the schema in a different issue), but if they are correct in the UI, they should be fixed here.

vijaycs85’s picture

Title: Fix typo in views schemas » Fix typo: lable to label
Status: Needs work » Needs review
Issue tags: -Quick fix, -D8MI, -VDC, -views configuration schema
FileSize
2.83 KB
PASSED: [[SimpleTest]]: [MySQL] 58,497 pass(es). View

Fixing other part of code base

vijaycs85’s picture

restoring tags...

Gábor Hojtsy’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: +language-config

Looks good.

YesCT’s picture

Status: Reviewed & tested by the community » Needs review
FileSize
2.78 KB
2.81 KB
PASSED: [[SimpleTest]]: [MySQL] 58,124 pass(es). View

i took out the general comment spelling corrections, lets keep this to just typos introduced in #1910606: Improve the configurations schemas for Views significantly.

+++ b/core/modules/views/config/schema/views.filter.schema.ymlundefined
@@ -9,6 +9,7 @@ views_filter_boolean:
   mapping:
     value:
       type: boolean
+      label: 'Value'

was this label just missing before?

Gábor Hojtsy’s picture

Status: Needs review » Reviewed & tested by the community

I'm fine with this arrangement too, the other typos can still be fixed elsewhere. The addition of that missing 'Value' label also looks fine.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 4d51cdf and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.