Replace the fallback node listing with a list controller

So no pager, node access and status filter anymore?

+++ b/core/modules/node/lib/Drupal/node/NodeListController.phpundefined
@@ -0,0 +1,96 @@
+    $row['type'] = check_plain(node_get_type_label($entity));

String::checkPlain()

Attaching patch from the dupe mentioned in #5.

Tested locally. Seems to clear the tests with 50+ nodes.
#6: 2021161-convert-node_admin_nodes-6.patch queued for re-testing.

Can you please make those associative arrays multiline? I know it's not in the coding standards, but it makes them so much more readable, especially because they exceed 80 characters and run off my screen. There is really no need to put them on one line.

Oh, whatever.

Would it be a good idea to make the node entity list controller implement FormInterface and in its render() method call drupal_get_form() on itself?

#1: node-2021161-1.patch queued for re-testing.

This is a simple re-roll of #1.

#15: drupal_2021161_15.patch queued for re-testing.

#15: drupal_2021161_15.patch queued for re-testing.

Additional from the small problems from below, this basically needs #2027115: Allow views to override existing routing items to work.

1. +++ b/core/modules/node/lib/Drupal/node/NodeListController.php
   @@ -0,0 +1,96 @@
   +    $row['type'] = check_plain(node_get_type_label($entity));
   

   Could be String::checkPlain and maybe even the entity_load for the node type could be used.

2. +++ b/core/modules/node/lib/Drupal/node/NodeListController.php
   @@ -0,0 +1,96 @@
   +    $row['status'] = $entity->status ? t('published') : t('not published');
   

   t() could also be $this->t() all over the place.

Anyone working on this? Would like to start converting the local task.

#2027115: Allow views to override existing routing items is commited

Now it is. :)

Just another rerole.

+++ b/core/modules/node/lib/Drupal/node/NodeListController.php
@@ -0,0 +1,163 @@
+   * Constructs a new DateFormatListController object.

Looks like a copy paste oops on the class name.

Thanks @dawehner nice work. Some more minor issues.

1. +++ b/core/modules/node/lib/Drupal/node/NodeListController.php
   @@ -0,0 +1,163 @@
   +      $header['language_name'] = array('data' => $this->t('Language'), 'class' => array(RESPONSIVE_PRIORITY_LOW));
   

   Please can we convert this to multiline as well.

2. +++ b/core/modules/node/lib/Drupal/node/NodeListController.php
   @@ -0,0 +1,163 @@
   +      '#href' => 'node/' . $entity->id(),
   ...
   +        'href' => 'node/' . $entity->id() . '/translations',
   

   $node->uri()

3. +++ b/core/modules/node/lib/Drupal/node/NodeListController.php
   @@ -0,0 +1,163 @@
   +  protected function t($string, array $args = array(), array $options = array()) {
   

   We should move this to base class.

We should move this to base class.

We do have indeed a t() function already in the base.

+++ b/core/modules/node/lib/Drupal/node/NodeListController.php
@@ -113,7 +104,7 @@ public function buildRow(EntityInterface $entity) {
+      '#href' => $entity->uri(),

It should be

+++ b/core/modules/node/lib/Drupal/node/NodeListController.php
@@ -113,7 +104,7 @@ public function buildRow(EntityInterface $entity) {
+       $uri = $entity->uri();
+      '#href' => $uri['path'],
+      '#options' => $uri['options'],

You are so right!

This can be added in by content_translation_entity_operation_alter() now (which doesn't exist but should), we want that for admin/people as well.

This is pretty cool.

It is RTBC for me but it is not green so some more minor issues.

1. +++ b/core/modules/node/lib/Drupal/node/NodeListController.php
   @@ -0,0 +1,139 @@
   +    parent::__construct($entity_type, $entity_info, $storage, $module_handler);
   +
   +    $this->dateService = $date_service;
   

   I think we can remove blank line.

2. +++ b/core/modules/node/lib/Drupal/node/NodeListController.php
   @@ -0,0 +1,139 @@
   +      $header['language_name'] = array('data' => $this->t('Language'), 'class' => array(RESPONSIVE_PRIORITY_LOW));
   

   Mutliline please.

3. +++ b/core/modules/node/lib/Drupal/node/NodeListController.php
   @@ -0,0 +1,139 @@
   +    $row['type'] = String::checkPlain(node_get_type_label($entity));
   

   NodeManager *sigh*. I think we have a issue about it.

4. +++ b/core/modules/node/lib/Drupal/node/NodeListController.php
   @@ -0,0 +1,139 @@
   +      $operations[$key]['query'] = $destination;
   +
   +    }
   

   We can also remove this blank line.

I think we can remove blank line.

I do prefer to separate the parent call.

39: vdc-2021161-39.patch queued for re-testing.

This is a rerole.

43: vdc-2021161.patch queued for re-testing.

Copy/paste comments form #1938884-36: Replace the fallback user listing with a list controller.

Committed and pushed to 8.x. Thanks!