Problem/Motivation

If a view for comments is created using the format settings Format: Unformatted list and Show: Comment | Full comment no output is rendered. Even tough the views summary says Displaying 1 - 489 of 489.

Proposed resolution

Needs a patch :)

Remaining tasks

User interface changes

None

API changes

None

Files: 
CommentFileSizeAuthor
#9 vdc-2020353-9.patch5.51 KBdawehner
PASSED: [[SimpleTest]]: [MySQL] 58,101 pass(es).
[ View ]
#9 interdiff.txt593 bytesdawehner
#5 vdc-2020353-5.patch5.55 KBdawehner
PASSED: [[SimpleTest]]: [MySQL] 57,642 pass(es).
[ View ]
#5 vdc-2020353-tests.patch5.04 KBdawehner
FAILED: [[SimpleTest]]: [MySQL] 56,243 pass(es), 1 fail(s), and 0 exception(s).
[ View ]
#1 comment-2020353-1.patch527 bytesdawehner
PASSED: [[SimpleTest]]: [MySQL] 56,223 pass(es).
[ View ]

Comments

dawehner’s picture

Status:Active» Needs review
StatusFileSize
new527 bytes
PASSED: [[SimpleTest]]: [MySQL] 56,223 pass(es).
[ View ]

Here is a fix.

dawehner’s picture

Issue tags:+Needs tests

Status:Needs review» Needs work
Issue tags:-Needs tests

The last submitted patch, comment-2020353-1.patch, failed testing.

das-peter’s picture

Status:Needs work» Needs review
Issue tags:+Needs tests

#1: comment-2020353-1.patch queued for re-testing.

dawehner’s picture

Priority:Normal» Major
StatusFileSize
new5.04 KB
FAILED: [[SimpleTest]]: [MySQL] 56,243 pass(es), 1 fail(s), and 0 exception(s).
[ View ]
new5.55 KB
PASSED: [[SimpleTest]]: [MySQL] 57,642 pass(es).
[ View ]

Tbh. i would consider this as major.

Status:Needs review» Needs work

The last submitted patch, vdc-2020353-tests.patch, failed testing.

dawehner’s picture

Status:Needs work» Needs review
Issue tags:+VDC

Back to needs review

damiankloip’s picture

+++ b/core/modules/comment/tests/modules/comment_test_views/test_views/views.view.test_comment_row.ymlundefined
@@ -0,0 +1,144 @@
+uuid: 86b00437-846d-40d8-9426-384bbe2c7c8e

We usually remove this from our test config?

Otherwise, looks good to me.

dawehner’s picture

Issue tags:-Needs tests
StatusFileSize
new593 bytes
new5.51 KB
PASSED: [[SimpleTest]]: [MySQL] 58,101 pass(es).
[ View ]

Okay let's remove it.

damiankloip’s picture

Status:Needs review» Reviewed & tested by the community

Super

alexpott’s picture

Status:Reviewed & tested by the community» Fixed

Committed 9bcaeed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.