Problem/Motivation

If a view for comments is created using the format settings Format: Unformatted list and Show: Comment | Full comment no output is rendered. Even tough the views summary says Displaying 1 - 489 of 489.

Proposed resolution

Needs a patch :)

Remaining tasks

User interface changes

None

API changes

None

CommentFileSizeAuthor
#9 vdc-2020353-9.patch5.51 KBdawehner
#9 interdiff.txt593 bytesdawehner
#5 vdc-2020353-5.patch5.55 KBdawehner
#5 vdc-2020353-tests.patch5.04 KBdawehner
#1 comment-2020353-1.patch527 bytesdawehner

Comments

dawehner’s picture

dawehner
Primary language German
commented
Status: Active » Needs review
StatusFileSize
new comment-2020353-1.patch527 bytes

Here is a fix.

dawehner’s picture

dawehner
Primary language German
commented
Issue tags: +Needs tests

Status: Needs review » Needs work
Issue tags: -Needs tests

The last submitted patch, comment-2020353-1.patch, failed testing.

das-peter’s picture

das-peter commented
Status: Needs work » Needs review
Issue tags: +Needs tests

#1: comment-2020353-1.patch queued for re-testing.

dawehner’s picture

dawehner
Primary language German
commented
Priority: Normal » Major
StatusFileSize
new vdc-2020353-tests.patch5.04 KB
new vdc-2020353-5.patch5.55 KB

Tbh. i would consider this as major.

Status: Needs review » Needs work

The last submitted patch, vdc-2020353-tests.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs work » Needs review
Issue tags: +VDC

Back to needs review

damiankloip’s picture

damiankloip commented 
+++ b/core/modules/comment/tests/modules/comment_test_views/test_views/views.view.test_comment_row.ymlundefined
@@ -0,0 +1,144 @@
+uuid: 86b00437-846d-40d8-9426-384bbe2c7c8e

We usually remove this from our test config?

Otherwise, looks good to me.

dawehner’s picture

dawehner
Primary language German
commented
Issue tags: -Needs tests
StatusFileSize
new interdiff.txt593 bytes
new vdc-2020353-9.patch5.51 KB

Okay let's remove it.

damiankloip’s picture

damiankloip commented
Status: Needs review » Reviewed & tested by the community

Super

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 9bcaeed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.