Allow the "With selection" label on bulk operation to be configured

The common label is "Bulk Actions"

Patch included.

But i wasn't able to confirm the title/label is translatable, as it didn't seem to get picked up by the config translation module.

Also, i expect this needs some tests to check it all works the way it should, but i might need some guidance there on where to start / direction to take etc.

+++ b/core/modules/system/lib/Drupal/system/Plugin/views/field/BulkFormBase.phpundefined
@@ -24,6 +24,24 @@
+  protected function defineOptions() {
...
+  public function buildOptionsForm(&$form, &$form_state) {

The codestyle (which is not properly done by views itself) is to put /** {@inheritdoc} */ on the functions.

Adding a tag.

adding docs inherit.

I would like to add the tests for this, but i'm not sure where to start.
Are there any good examples of how similar tests were done?

Let's add some tests.

+++ b/core/modules/action/lib/Drupal/action/Tests/BulkFormTest.phpundefined
@@ -86,6 +86,16 @@ public function testBulkForm() {
+    $this->drupalGet('test_bulk_form');
+    $result = $this->xpath('//label[@for="edit-action"]');
+    $this->assertEqual('Test title', (string) $result[0]);

I think it is worth asserting the default label before changing it and saving the view.

There we go.

Otherwise, I just manually tested again - this is working well. RTBC.

I just changed the test comment from label to comment just to keep things uniform, and felt bad asking you to reroll again because of that!

#10: 2020111-10.patch queued for re-testing.

And back.

We need to update the views config schema so that it's translatable.

Sometimes you eat tags, sometimes you spit them out.

> We need to update the views config schema so that it's translatable.

What does that mean? I don't see anything else in views.field.schema.yml that is marked as translatable.

Patch currently applies with fuzz, so we're probably fine without a reroll for now.

Rerolled, this patch already has the schema definition for the action_title property. So I think we are good?

Actually, the schema definition for this should live in action module, as that's where the field handler comes from.

Back to rtbc

18: 2020111-18.patch queued for re-testing.

Committed and pushed to 8.x. Thanks!