Various comments in breakpoint.module and breakpoint.install erroneosly refer to #1813100: Allow different naming schema for yaml files while they should point to #1813110: Introduce a function "is it a module or is it a theme?":
* @todo: This should be removed if https://drupal.org/node/1813100 is resolved.

Files: 
CommentFileSizeAuthor
#6 breakpoint-fix-issue-referral-2019907-6.patch1.76 KBianthomas_uk
PASSED: [[SimpleTest]]: [MySQL] 58,341 pass(es).
[ View ]
#5 breakpoint-fix-issue-referral-2019907-5.patch1.76 KBianthomas_uk
PASSED: [[SimpleTest]]: [MySQL] 58,036 pass(es).
[ View ]
#3 breakpoint-fix-issue-referral-2019907-3.patch1.75 KBianthomas_uk
PASSED: [[SimpleTest]]: [MySQL] 58,529 pass(es).
[ View ]
#1 breakpoint-fix-issue-referral-2019907.patch2.28 KBPancho
PASSED: [[SimpleTest]]: [MySQL] 57,019 pass(es).
[ View ]

Comments

Pancho’s picture

Status:Active» Needs review
StatusFileSize
new2.28 KB
PASSED: [[SimpleTest]]: [MySQL] 57,019 pass(es).
[ View ]
Pancho’s picture

ianthomas_uk’s picture

Status:Needs review» Reviewed & tested by the community
StatusFileSize
new1.75 KB
PASSED: [[SimpleTest]]: [MySQL] 58,529 pass(es).
[ View ]

Marking RTBC to say that 1813100 should be 1813110. The patch will fail against breakpoint.install, as webchick removed that comment while fixing another issue (http://drupalcode.org/project/drupal.git/commitdiff/c379479e29cea633cce3...), but the remainder of the patch is still valid.

I've attached a version of the patch without the change to breakpoint.install (otherwise identical - you can use the earlier patch and just ignore the rejected hunk if you prefer).

webchick’s picture

Status:Reviewed & tested by the community» Needs review

Wait, why are we removing the s from https? All D.o URLs are https now, so this will cause an unnecessary redirect.

ianthomas_uk’s picture

StatusFileSize
new1.76 KB
PASSED: [[SimpleTest]]: [MySQL] 58,036 pass(es).
[ View ]

I didn't realise there was a redirect in place. Here's a version with the s.

ianthomas_uk’s picture

StatusFileSize
new1.76 KB
PASSED: [[SimpleTest]]: [MySQL] 58,341 pass(es).
[ View ]

Here is a re-roll because function breakpoint_modules_enabled() was renamed breakpoint_modules_installed().

haydeniv’s picture

Status:Needs review» Reviewed & tested by the community

Easy peasy lemon squeezy. RTBC as #4 is dealt with.

catch’s picture

Status:Reviewed & tested by the community» Fixed

Committed/pushed to 8.x, thanks!

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.