The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.Various comments in breakpoint.module and breakpoint.install erroneosly refer to #1813100: Allow different naming schema for yaml files while they should point to #1813110: Introduce a function "is it a module or is it a theme?":
* @todo: This should be removed if https://drupal.org/node/1813100 is resolved.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | breakpoint-fix-issue-referral-2019907-6.patch | 1.76 KB | ianthomas_uk |
| #5 | breakpoint-fix-issue-referral-2019907-5.patch | 1.76 KB | ianthomas_uk |
| #3 | breakpoint-fix-issue-referral-2019907-3.patch | 1.75 KB | ianthomas_uk |
| #1 | breakpoint-fix-issue-referral-2019907.patch | 2.28 KB | pancho |
Comments
Comment #1
panchoComment #2
pancho#1: breakpoint-fix-issue-referral-2019907.patch queued for re-testing.
Comment #3
ianthomas_ukMarking RTBC to say that 1813100 should be 1813110. The patch will fail against breakpoint.install, as webchick removed that comment while fixing another issue (http://drupalcode.org/project/drupal.git/commitdiff/c379479e29cea633cce3...), but the remainder of the patch is still valid.
I've attached a version of the patch without the change to breakpoint.install (otherwise identical - you can use the earlier patch and just ignore the rejected hunk if you prefer).
Comment #4
webchickWait, why are we removing the s from https? All D.o URLs are https now, so this will cause an unnecessary redirect.
Comment #5
ianthomas_ukI didn't realise there was a redirect in place. Here's a version with the s.
Comment #6
ianthomas_ukHere is a re-roll because function breakpoint_modules_enabled() was renamed breakpoint_modules_installed().
Comment #7
haydeniv commentedEasy peasy lemon squeezy. RTBC as #4 is dealt with.
Comment #8
catchCommitted/pushed to 8.x, thanks!