Closed (fixed)
Project:
Translation template extractor
Version:
7.x-3.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
14 Jun 2013 at 13:27 UTC
Updated:
27 Sep 2014 at 23:03 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
gábor hojtsyComment #2
gábor hojtsy#2018411: Figure out a nice DX when working with injected translation is not yet decided, so I don't think we can do anything here yet.
Comment #3
gábor hojtsy#2018411-34: Figure out a nice DX when working with injected translation says it is settled on $this->t(), that is what should be supported. This is an alter-ego of t() from the POV of potx. Any $this->t() should be parsed as t().
Comment #4
herom commentedI guess this was never an issue. Because from the point of view of tokens, the "t" in $this->t is no different from just calling "t"; they are bost T_STRING.
I have confirmed this by checking for some strings manually.
Comment #5
gábor hojtsyWow, it just works? Wow!
Comment #6
gábor hojtsyCan we add test coverage to prove/ensure it works? :)
Comment #7
herom commentedsomething like this?
Comment #8
gábor hojtsyYay, committed that to 6.x-3.x. Needs to be ported to 7. Thanks a lot!
Comment #9
yesct commentedMaybe a tiny related.
Comment #12
SebCorbin commentedPorted to 7.x-3.x as it has been branched directly from 6.x-3.x