Declaration of taxonomy_facet::build_root_categories_query() should be compatible with faceted_search_facet::build_root_categories_query() in /home/vhosts/valleyf/site/site/includes/bootstrap.inc on line 710.

just curious what's going on. I moved the server from old centos php 5.2 to ubuntu php 5.4 and this starts showing up. Things seem to work OK though

any advice?

cheers

-z

CommentFileSizeAuthor
#1 faceted_search-inconsistent-function-signature-2019433-1.patch403 bytesdavid lesieur

Comments

david lesieur’s picture

david lesieur commented
Version: 6.x-1.0-beta2 » 6.x-1.x-dev
Status: Active » Needs review
StatusFileSize
new faceted_search-inconsistent-function-signature-2019433-1.patch403 bytes

The arguments to the build_root_categories_query() method were inconsistent between the base class and its subclasses. Previous versions of PHP ignored that mistake, but PHP 5.4 is kind enough to warn us. The attached patch should fix this.

david lesieur’s picture

david lesieur commented
Status: Needs review » Fixed

Committed!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.