Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
CSS
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
13 Jun 2013 at 15:25 UTC
Updated:
29 Jul 2014 at 22:31 UTC
Jump to comment: Most recent, Most recent file


Comments
Comment #1
ekl1773Followed recommendation in the issue description: the margin, padding and border are only applied when JavaScript is enabled. Also added rtl styling accordingly.
Comment #2
jessebeach commentedAdded a newline to the end of the vertical-tabs-rtl.css
Comment #3
rteijeiro commentedPatch applies well and code seems right.
Tested disabling Javascript and box expands correctly.
Maybe RTBC?
Comment #4
jessebeach commentedIf the bot comes back green (and there's no reason it shouldn't), then RTBC from me as well.
Comment #6
jessebeach commentedDrupal\views_ui\Tests\OverrideDisplaysTestThis has nothing to do with Views UI. TestBot hiccup. Respooling.
Comment #7
jessebeach commented#2: Vertical-tabs-gap-2018913-2.patch queued for re-testing.
Comment #8
Zarabadoo commentedThis looks good to me, and it seems there there is. Marking as RTBC.
Comment #9
alexpottCommitted 614550d and pushed to 8.x. Thanks!
Comment #10
echoz commented@jessebeach, why would we qualify class .js with the html element selector?