Get rid of node_hook and node_invoke

I thought we'd removed hook_load and friends already. Yes please, they all need to die.

+++ b/core/modules/node/node.module
+++ b/core/modules/node/node.module
@@ -865,6 +865,8 @@ function node_rdf_mapping() {

@@ -865,6 +865,8 @@ function node_rdf_mapping() {
  *
  * @return string|false
  *   A string containing the function name or FALSE if it isn't found.
+ *
+ * @deprecated as of Drupal 8.0. Do not use this.
  */
 function node_hook($type, $hook) {

Why not just remove?

+  if (!$node->isNew()) {
+    $forum_terms = $node->taxonomy_forums;

Is this really always set? Otherwise looks amazing.

+++ b/core/modules/node/lib/Drupal/node/NodeFormController.phpundefined
@@ -341,13 +338,9 @@ public function validate(array $form, array &$form_state) {
     // Can't use node_invoke() or module_invoke_all(), because $form_state must
     // be receivable by reference.
-    if ($function = node_hook($node->type, 'validate')) {
-      $function($node, $form, $form_state);

This still talks about node_invoke().

+++ b/core/modules/node/node.api.phpundefined
@@ -1105,7 +1052,7 @@ function hook_prepare(\Drupal\Core\Entity\EntityInterface $node) {
-function hook_form(\Drupal\Core\Entity\EntityInterface $node, &$form_state) {
+function hook_node_form(\Drupal\Core\Entity\EntityInterface $node, &$form_state) {
   $type = node_type_load($node->type);

That actually exists?

+++ b/core/modules/node/node.moduleundefined
@@ -3112,29 +3074,6 @@ function _node_access_rebuild_batch_finished($success, $results, $operations) {
  * @} End of "defgroup node_content".

The @defgroup definition is right above node_content_form(), looks like we can kill that? anything left that references it?

Agreed, this looks great.

Don't see anything left to do here.

Here is some old hooks mentions in comments.
If anyone with good English please check.

/d8/core/modules/node/node.api.php (2 hits)
Line 510: * read from the database or the entity cache, hook_load() is invoked on the
Line 521: * module defines a content type, you can use hook_load() to respond to
/d8/core/modules/node/node.api.php (1 hits)
Line 400: * hook_delete() has been invoked, but before hook_entity_predelete() and
/d8/core/modules/file/lib/Drupal/file/Tests/ValidateTest.php (1 hits)
Line 40: // Now test for failures in validators passed in and by hook_validate.
/d8/core/modules/node/node.api.php (1 hits)
Line 731: * hook_validate() is invoked.
/d8/core/modules/node/node.api.php (1 hits)
Line 677: * type-specific hook_update() is invoked, and after field_attach_update() is
/d8/core/modules/node/node.api.php (2 hits)
Line 25: * content type as "forum", so during creation of a forum node, hook_insert() is
Line 457: * type-specific hook_insert() is invoked, and after field_attach_insert() is
/d8/core/modules/node/lib/Drupal/node/NodeFormController.php (1 hits)
Line 23: * Fills in a few default values, and then invokes hook_prepare() on the node
/d8/core/modules/node/node.api.php (1 hits)
Line 612: * type-specific hook_prepare() is invoked.

couldnt find occurences and docs look good

Committed/pushed to 8.x, thanks!

Will need a change notice.

No that's plenty, thanks!