Move entity_reference_get_selection_handler() to a method on SelectionPluginManager

I don't see anything wrong with that, let's do it :)

Let's see what I broke

Let's see if this goes green, hopefully patch is aligned with the intention of the issue :)

+++ b/core/modules/entity_reference/lib/Drupal/entity_reference/Plugin/Type/SelectionPluginManager.php
@@ -85,4 +85,26 @@ public function getSelectionGroups($entity_type) {
+   * @param $field
+   *   The field structure for the operation.
+   * @param $instance
+   *   The instance structure for $field on $entity's bundle.
+   * @param \Drupal\Core\Entity\EntityInterface|\Drupal\entity_reference\Plugin\Type\EntityInterface $entity
+   *   The entity for the operation.

$field and $instance are missing the 'array' data type, and $entity should be just \Drupal\Core\Entity\EntityInterface.

Otherwise we're good here :)

Yep, you're totally right.

Ok had big re-roll conflict issues so no interdiff on the doc changes :( but here is the patch!

Looks good to go :)

Needs another reroll for #2020405: Correct misspelling of 'referenceable' :(

Here's the reroll. Should still be RTBC, when green.

RTBC as for #12

This issue was RTBC and passing tests on July 1, the beginning of API freeze.

Should we actually be removing the function entity_reference_get_selection_handler() as well? It was a one point but in #10 it was no longer removed... can't determine why... as this patch does appear to remove all 10 usages from core.

Also needs a reroll..

curl https://drupal.org/files/2017851-move_entity_reference_get_selection_handler-13.patch | git apply
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  9486  100  9486    0     0   9800      0 --:--:-- --:--:-- --:--:-- 12038
error: patch failed: core/modules/entity_reference/lib/Drupal/entity_reference/Plugin/Type/SelectionPluginManager.php:10
error: core/modules/entity_reference/lib/Drupal/entity_reference/Plugin/Type/SelectionPluginManager.php: patch does not apply

Yes, we should. I guess it was just a victim of the big conflict reroll from #10..

Rerolled and deleted the deprecated function.

Back to RTBC since the patch is really trivial :)

+++ b/core/modules/entity_reference/lib/Drupal/entity_reference/Plugin/Type/SelectionPluginManager.phpundefined
@@ -91,4 +93,24 @@ public function getSelectionGroups($entity_type) {
+    return \Drupal::service('plugin.manager.entity_reference.selection')->getInstance($options);

I might be missing something... but shouldn't we using $this->getInstance($options); here?

Of course we should, me--. Got to respect that self-imposed break more :)

#21: 2017851-move_entity_reference_get_selection_handler-21.patch queued for re-testing.

+++ b/core/modules/entity_reference/lib/Drupal/entity_reference/EntityReferenceAutocomplete.phpundefined
@@ -70,7 +70,7 @@ public function getMatches($field, $instance, $entity_type, $entity_id = '', $pr
-    $handler = entity_reference_get_selection_handler($instance, $entity);
+    $handler = \Drupal::service('plugin.manager.entity_reference.selection')->getSelectionHandler($instance, $entity);

EntityReferenceAutocomplete is a service, so this can be easily injected

+++ b/core/modules/entity_reference/lib/Drupal/entity_reference/Plugin/field/widget/AutocompleteTagsWidget.phpundefined
@@ -39,7 +39,7 @@ class AutocompleteTagsWidget extends AutocompleteWidgetBase {
+    $handler = \Drupal::service('plugin.manager.entity_reference.selection')->getSelectionHandler($this->fieldDefinition);

We really need to fix/kill WidgetFactory...

+++ b/core/modules/entity_reference/lib/Drupal/entity_reference/Tests/EntityReferenceSelectionSortTest.phpundefined
@@ -121,7 +121,7 @@ public function testSort() {
+    $handler = \Drupal::service('plugin.manager.entity_reference.selection')->getSelectionHandler($instance);

@@ -137,7 +137,7 @@ public function testSort() {
+    $handler = \Drupal::service('plugin.manager.entity_reference.selection')->getSelectionHandler($instance);

+++ b/core/modules/entity_reference/lib/Drupal/entity_reference/Tests/Views/SelectionTest.phpundefined
@@ -70,7 +70,7 @@ public function testSelectionHandler() {
+    $handler = \Drupal::service('plugin.manager.entity_reference.selection')->getSelectionHandler($instance);

This could be $this->container->get(...

Thanks, Tim!

Can we get an issue for WidgetFactory to extend or be replaced by ContainerFactory? Thanks!

Committed 42ebadc and pushed to 8.x. Thanks!

Created followup #2052751: WidgetFactory is not used anywhere so it should be removed