Part of #1929270: [meta] Drupal-agnostic components should not be calling Drupal functions
actually it calls get_t
converted it to String::format, dunno if its the appropriate solution though since those strings cant be translated now
I wanted to find out where $_errors is used, but couldn't find anything. On top of that, it's declared as private, so... very strange!
Agreed with this change!
It is/was supposed to have an accessor method and the error be logged or something (if used in an already set up environment)?
Let's do this then. I checked again and there's no usage of $_errors in the entirety of core/lib outside of the ones being touched here. In the long run, we probably do want to log this properly, but that should be sorted out on its own.
Needs a reroll
curl https://drupal.org/files/drupal-postreamreader_get_t-2017345-1.patch | git a
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 8480 100 8480 0 0 4391 0 0:00:01 0:00:01 --:--:-- 6838
error: patch failed: core/lib/Drupal/Component/Gettext/PoStreamReader.php:280
error: core/lib/Drupal/Component/Gettext/PoStreamReader.php: patch does not apply
Here is the reroll
thank you pwieck!
Committed b22c7a5 and pushed to 8.x. Thanks!
Automatically closed -- issue fixed for 2 weeks with no activity.
Drupal is a registered trademark of Dries Buytaert.