| Comment | File | Size | Author |
|---|---|---|---|
| #7 | drupal-postreamreader_get_t-2017345-7.patch | 7.96 KB | pwieck |
| #2 | drupal-postreamreader_get_t-2017345-1.patch | 8.28 KB | ParisLiakos |
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | drupal-postreamreader_get_t-2017345-7.patch | 7.96 KB | pwieck |
| #2 | drupal-postreamreader_get_t-2017345-1.patch | 8.28 KB | ParisLiakos |
Comments
Comment #1
ParisLiakos commentedactually it calls get_t
Comment #2
ParisLiakos commentedconverted it to String::format, dunno if its the appropriate solution though since those strings cant be translated now
Comment #3
tstoecklerI wanted to find out where $_errors is used, but couldn't find anything. On top of that, it's declared as private, so... very strange!
Comment #4
gábor hojtsyAgreed with this change!
It is/was supposed to have an accessor method and the error be logged or something (if used in an already set up environment)?
Comment #5
tstoecklerLet's do this then. I checked again and there's no usage of $_errors in the entirety of core/lib outside of the ones being touched here. In the long run, we probably do want to log this properly, but that should be sorted out on its own.
Comment #6
alexpottNeeds a reroll
Comment #7
pwieck commentedHere is the reroll
Comment #8
ParisLiakos commentedthank you pwieck!
looks good
Comment #9
alexpottCommitted b22c7a5 and pushed to 8.x. Thanks!