Files: 
CommentFileSizeAuthor
#7 drupal-postreamreader_get_t-2017345-7.patch7.96 KBpwieck
PASSED: [[SimpleTest]]: [MySQL] 58,390 pass(es).
[ View ]
#2 drupal-postreamreader_get_t-2017345-1.patch8.28 KBParisLiakos
PASSED: [[SimpleTest]]: [MySQL] 57,139 pass(es).
[ View ]

Comments

ParisLiakos’s picture

Title:Drupal\Component\Gettext\PoStreamReader calls t()» Drupal\Component\Gettext\PoStreamReader calls get_t()

actually it calls get_t

ParisLiakos’s picture

Status:Active» Needs review
StatusFileSize
new8.28 KB
PASSED: [[SimpleTest]]: [MySQL] 57,139 pass(es).
[ View ]

converted it to String::format, dunno if its the appropriate solution though since those strings cant be translated now

tstoeckler’s picture

I wanted to find out where $_errors is used, but couldn't find anything. On top of that, it's declared as private, so... very strange!

Gábor Hojtsy’s picture

Agreed with this change!

It is/was supposed to have an accessor method and the error be logged or something (if used in an already set up environment)?

tstoeckler’s picture

Status:Needs review» Reviewed & tested by the community

Let's do this then. I checked again and there's no usage of $_errors in the entirety of core/lib outside of the ones being touched here. In the long run, we probably do want to log this properly, but that should be sorted out on its own.

alexpott’s picture

Status:Reviewed & tested by the community» Needs work
Issue tags:+Needs reroll

Needs a reroll

curl https://drupal.org/files/drupal-postreamreader_get_t-2017345-1.patch | git a
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  8480  100  8480    0     0   4391      0  0:00:01  0:00:01 --:--:--  6838
error: patch failed: core/lib/Drupal/Component/Gettext/PoStreamReader.php:280
error: core/lib/Drupal/Component/Gettext/PoStreamReader.php: patch does not apply
pwieck’s picture

Status:Needs work» Needs review
StatusFileSize
new7.96 KB
PASSED: [[SimpleTest]]: [MySQL] 58,390 pass(es).
[ View ]

Here is the reroll

ParisLiakos’s picture

Status:Needs review» Reviewed & tested by the community

thank you pwieck!
looks good

alexpott’s picture

Status:Reviewed & tested by the community» Fixed
Issue tags:-Needs reroll

Committed b22c7a5 and pushed to 8.x. Thanks!

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.