Breadcrumb - not replaced % mark in the title of views.
patch is :

- $breadcrumb[] = l(filter_xss_admin(views_get_title($view, 'page', $args)), $url, NULL, NULL, NULL, NULL, TRUE);
+ $breadcrumb[] = l(filter_xss_admin(views_get_title($view, 'page')), $url, NULL, NULL, NULL, NULL, TRUE);

CommentFileSizeAuthor
views.patch573 bytesDimm

Comments

kscheirer’s picture

kscheirer
Primary language English
Location Vallejo
commented

regarding that line of code,

I notice that there's no check to make sure views_get_title() actually returns text. If the user doesn't enter a view title, l() will still happily make a link and insert it in the breadcrumb, as something like 

<a href="viewurl"></a>

which results in breadcrumbs like: Home > > Argument1

I'd be happy to create a patch to add this check if anyone else has had the same problem.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Component: User interface » Code
Assigned: Dimm » Unassigned
Status: Reviewed & tested by the community » Needs work

Yes, please add that check.
This patch also needs some positive test results from other users to be included in 1.7.

ryo’s picture

ryo commented

Unfortunately the patch doesn't work for me...
Views titles duplicate in the breadcrumbs.
Please see also
Wrong breadcrumbs when view with argument is in menu

If you have the whole following line (line: 1486)
//$breadcrumb[] = l(filter_xss_admin(views_get_title($view, 'page', $args)), $url, NULL, NULL, NULL, NULL, TRUE);
commented out and have the menu items for your view pages,
things go quite well.
But instead, if you don't have menu items, disappears the breadcrumb of the parent (no argument) view's title.

esmerel’s picture

esmerel commented
Status: Needs work » Closed (won't fix)

This is not going to get fixed in 1.x