Regression: Refactor 'autocreate entity' handling from entity_reference

Thanks @amateescu !
RTBC +1 (although I did write part of the code)

- add an explicit 'target_id' => 0 in autocreate items, according to what has been settled in #2012662: Constraints on 'target_id' / 'tid' properties break autocomplete if applied
- The formatters need to be adjusted accordingly for the new convention (there is no 'target_id' = 'autocreate' anymore)

Er, wrong interdiff.

testbot seems a bit lazy - reuploading

Committed cd8a251 and pushed to 8.x. Thanks!

Ooops - trivial coding style followup.

Committed 82d44b7 and pushed to 8.x. Thanks!

Can someone explain the following, it looks weird to me:

+++ b/core/modules/entity_reference/lib/Drupal/entity_reference/Plugin/field/widget/AutocompleteWidgetBase.php
@@ -120,4 +124,39 @@ protected function getLabels(array $items) {
+    // Get the bundle.
+    if (!empty($this->instance['settings']['handler_settings']['target_bundles']) && count($this->instance['settings']['handler_settings']['target_bundles']) == 1) {
+      $bundle = reset($this->instance['settings']['handler_settings']['target_bundles']);
+    }
+    else {
+      $bundles = entity_get_bundles($target_type);
+      $bundle = reset($bundles);

the count() == 1 check here seems wrong. If multiple target bundles are specified, the chosen one should still be one of them, and not a random one, right?

Re-opening this for now as a reminder, fine with handling this in a follow-up.

@agentrickard asked in IRC about notices/fatal errors on entity_reference.module:123, which this patch changes for domain.module. I can reproduce on both Node and Term, not sure why our tests aren't failing?

To reproduce:
- Add a reference field on nodes pointing to nodes. Tested with both autocomplete and options list widgets
- Try to create a node with a refererence.
- Fatal error called to method isNew on non-object.

Confirming that the last patch fixes my failing tests ;-).

Thats great, but we need a regression test and understand why our current tests are not failing and while we're at it, also understand why entity isn't there.. it should be IMHO :)

Fine with me, I think that issue might get in soon :)

I think the tag was removed accidently?

That main issue #1969728: Implement Field API "field types" as TypedData Plugins is in. Are there followups we care about here?

Hm. Something changed in the last week, as my original tests no longer fail, nor does the similar test I wrote for this issue.

That means the field types conversion fixed it. Wondering if we can close this without having to add test, as we still don't know why exactly the tests didn't fail...

Here's the new test file, if we want to include it anyway.

+++ b/core/modules/entity_reference/lib/Drupal/entity_reference/Tests/EntityReferenceAutoCreateTest.phpundefined
@@ -110,5 +113,9 @@ public function testAutoCreate() {
+    $this->assertNoText('Exception');

Let's make this a "positive" test, by verifying that the referenced thing is actually displayed, not that no error is there.

Tests for core (and my contrib) are green locally, so this is RTBC when the bot catches up.

Yes, this looks good.

Committed 82d9d6f and pushed to 8.x. Thanks!