Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
views_ui.module
Priority:
Major
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
10 Jun 2013 at 09:41 UTC
Updated:
29 Jul 2014 at 22:30 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
damiankloip commentedWaaa, sorry. Let's add the usesRowPlugin option to the test style plugin too - so the test is fairer.
Comment #3
damiankloip commentedForgot about the style plugin test. If we just move around the assertions and setUsesRowPlugin to FALSE instead of TRUE, we should be good for both tests.
Comment #4
les limChanging status for tests.
Comment #6
damiankloip commented#3: 2015999.patch queued for re-testing.
Comment #7
dawehnerShould we also check that $view->rowPlugin is now not an instance of RowTest?
Beside from this, this looks perfect.
Comment #8
damiankloip commentedYeah. let's do it! I thought we might as well check that it is using the Fields row plugin instead.
Comment #9
dawehnerThank you!
Comment #10
catchI know it's already there, but two cases of 'Take sure' in lines that are changed.
Comment #11
damiankloip commentedFair point, changed those lines.
Comment #12
dawehnerI'm sorry for all the "take" sure all over the place.
Comment #13
alexpottThis should be something like...
Can the style plugin use row plugins.Comment #14
damiankloip commentedYep, sure. Fixed.
Comment #15
damiankloip commentedErrhhhmm, Let's try that again.
Comment #16
damiankloip commentedAnd back again.
Comment #17
dawehner+1
Comment #18
alexpottCommitted 62ed405 and pushed to 8.x. Thanks!
Comment #19
effulgentsia commentedWhat's this file for?
Comment #20
damiankloip commentedGood question!
Comment #21
effulgentsia commentedIn case it's not there for a reason, here's the patch to remove it.
Comment #22
dawehnerWould be cool to understand what added the file in the first place.
Comment #23
damiankloip commentedIts a mistake, beyond doubt.
Comment #24
neclimdulLooks like it got added in #8. assume it was just an accident on the command line. things happen and its hard to see in the patch. RTBC for sure. Maybe the first 0 line patch? ;)
Comment #25
alexpottWhoops should have caught that on review... my bad.
Committed f36f480 and pushed to 8.x. Thanks!
Comment #26.0
(not verified) commentedUpdated issue summary.