Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.With the death of Open ID, so went the only usage of the rather hacky entity_form_submit().
Removing that also means we can inline entity_form_state_defaults().
In addition, entity_form_controller() hasn't be in use since #1831264: Use the Entity manager to create new controller instances.
And the last extraneous entity form function left in entity.inc was entity_form_submit_build_entity(), which was supposed to have been inlined into EntityFormController::buildEntity(), which I did.
2 files changed, 36 insertions(+), 121 deletions(-)
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | small-entity-inc-5.patch | 4.72 KB | chx |
| #7 | interdiff.txt | 746 bytes | chx |
Comments
Comment #2
tim.plunkettPostponing on #2059245: Add a FormBase class containing useful methods
Comment #3
daffie CreditAttribution: daffie commentedComment #4
tim.plunkettComment #5
plopescBasic re-roll, including minor changes.
Some changes have been addressed in other issues.
Regards.
Comment #6
andypostI see no reason to deprecate this
Comment #7
chx CreditAttribution: chx commentedConfirmed with timplunkett:
\Drupal::entityManager()is just$this, look at what class we are in. I will re-RTBC once the bot picks upComment #8
chx CreditAttribution: chx commentedComment #9
xjm7: small-entity-inc-5.patch queued for re-testing.
Comment #10
webchickNice diffstat. :)
Committed and pushed to 8.x. Thanks!