Depends on #1969728: Implement Field API "field types" as TypedData Plugins
Instructions are on #2014671: [META] Convert all field types to plugins

CommentFileSizeAuthor
#7 field_type_telephone-2015683-7.patch5.41 KBplopesc
#7 interdiff.txt424 bytesplopesc
#5 field_type_telephone-2015683-5.patch5.61 KBplopesc

Comments

swentel’s picture

swentel commented
Title: Convert field type to data plugin for telephone module » Convert field type to typed data plugin for telephone module
swentel’s picture

swentel commented

commit in sandbox, see http://drupalcode.org/sandbox/yched/1736366.git/commitdiff/d2fb7014a9f5b...

swentel’s picture

swentel commented
Status: Postponed » Active
plopesc’s picture

plopesc
he/him
Primary language Spanish
commented

Trying to take it ...

plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
Status: Active » Needs review
StatusFileSize
new field_type_telephone-2015683-5.patch5.61 KB

Hello

Attaching first approach to convert telephone field to typed data plugin.

Regards

swentel’s picture

swentel commented 
+++ b/core/modules/telephone/telephone.moduleundefined
@@ -43,4 +22,4 @@ function telephone_field_formatter_info_alter(&$info) {
\ No newline at end of file

Small nitpick, should be a newline here, unless dreditor is doing something wrong.

Other than that, this is as good as RTBC! Thanks already!

plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
StatusFileSize
new interdiff.txt424 bytes
new field_type_telephone-2015683-7.patch5.41 KB

Re-rolling patch.

Regards.

swentel’s picture

swentel commented
Status: Needs review » Reviewed & tested by the community

Looks good to me, thanks!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 389338d and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.