The renderExposedForm() method on ExposedFormPluginBase currently returns a rendered string, as with other handlers, we want this to return a render array. Otherwise theme_views_ui_view_preview_section() calls drupal_render() on a string in this case and therefore returns nothing.

A test should be added to check empty areas and exposed filters are rendered in the preview.

Patch to follow.

Files: 
CommentFileSizeAuthor
#3 2015165-3.patch5.85 KBdamiankloip
PASSED: [[SimpleTest]]: [MySQL] 55,470 pass(es). View
#3 interdiff-2015165-3.txt933 bytesdamiankloip
#1 2015165-test-only.patch4.33 KBdamiankloip
FAILED: [[SimpleTest]]: [MySQL] 55,430 pass(es), 1 fail(s), and 0 exception(s). View
#1 2015165.patch4.94 KBdamiankloip
FAILED: [[SimpleTest]]: [MySQL] 56,459 pass(es), 2 fail(s), and 1 exception(s). View

Comments

damiankloip’s picture

Issue tags: -Needs tests
FileSize
4.94 KB
FAILED: [[SimpleTest]]: [MySQL] 56,459 pass(es), 2 fail(s), and 1 exception(s). View
4.33 KB
FAILED: [[SimpleTest]]: [MySQL] 55,430 pass(es), 1 fail(s), and 0 exception(s). View

Status: Needs review » Needs work

The last submitted patch, 2015165.patch, failed testing.

damiankloip’s picture

Status: Needs work » Needs review
FileSize
933 bytes
5.85 KB
PASSED: [[SimpleTest]]: [MySQL] 55,470 pass(es). View

Need to also fix the ExposedFormTest as renderExposedForm() outputs a render array instead of a string. The test-only patch above is still good, and shows the particular failure that it should do.

dawehner’s picture

Status: Needs review » Reviewed & tested by the community

Nice stuff!

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 07c6057 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.