Exposed forms are not rendered in the Views UI preview [#2015165]

The renderExposedForm() method on ExposedFormPluginBase currently returns a rendered string, as with other handlers, we want this to return a render array. Otherwise theme_views_ui_view_preview_section() calls drupal_render() on a string in this case and therefore returns nothing.

A test should be added to check empty areas and exposed filters are rendered in the preview.

Patch to follow.

Comment	File	Size	Author
#3	2015165-3.patch	5.85 KB	damiankloip
#3	interdiff-2015165-3.txt	933 bytes	damiankloip
#1	2015165-test-only.patch	4.33 KB	damiankloip
#1	2015165.patch	4.94 KB	damiankloip

Comments

Comment #1

damiankloip commented 8 June 2013 at 09:35

Issue tags:

-Needs tests

Status	File	Size
new	2015165.patch	4.94 KB
new	2015165-test-only.patch	4.33 KB

Comment #2

8 June 2013 at 11:21

Status:

Needs review

» Needs work

The last submitted patch, 2015165.patch, failed testing.

Comment #3

damiankloip commented 8 June 2013 at 13:23

Status:

Needs work

» Needs review

Status	File	Size
new	interdiff-2015165-3.txt	933 bytes
new	2015165-3.patch	5.85 KB

Need to also fix the ExposedFormTest as renderExposedForm() outputs a render array instead of a string. The test-only patch above is still good, and shows the particular failure that it should do.