Running the testsuite for sqlite database there are a lot of errors

Error: unable to open database "sites/dev/files/unish.sqlite": unable to open database file

which is fixed through mkdir in _drush_sql_create

and next for the test testSqlConnect

sqlite3: Error: too many options: -e "select name from users where uid = 1;"

After some hours spend :( it came down to being unable to use the non existing give path.

Attached patch has some code style fixes for drush.sql.inc

CommentFileSizeAuthor
#2 drush.sql_.2014519-2.patch3.57 KBhelmo
drush-sqlite-restore-database.patch4.47 KBclemens.tolboom

Comments

clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
commented

XREF
#1386440: Test for valid DB parameters immediately when using --db-url with arr

helmo’s picture

helmo commented
StatusFileSize
new drush.sql_.2014519-2.patch3.57 KB

Here's an updated patch ... now also included in https://github.com/helmo/drush/pull/2 to let travis test it.

The code cleanup from this patch was moved to: #2034731: Collected code style fixes

moshe weitzman’s picture

moshe weitzman commented
Status: Needs review » Fixed

Committed to 6. Does not apply cleanly to 5.

helmo’s picture

helmo commented
Status: Fixed » Needs review

Any reason why you've only committed the changes to tests/sqlConnectTest.php and not commands/sql/sql.drush.inc?

The pull request has been rebased: https://travis-ci.org/helmo/drush/builds/8839622

moshe weitzman’s picture

moshe weitzman commented
Status: Needs review » Fixed

Committed. Sorry about that.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.